From: Quan Nguyen <quan@os.amperecomputing.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support
Date: Mon, 1 Mar 2021 19:46:08 +0700 [thread overview]
Message-ID: <f4b00f4c-6e6c-810d-d16d-5d01ebf4d36d@os.amperecomputing.com> (raw)
In-Reply-To: <20210226083114.GE641347@dell>
On 26/02/2021 15:31, Lee Jones wrote:
> On Thu, 25 Feb 2021, Quan Nguyen wrote:
>
>> Adds an MFD driver for SMpro found on the Mt.Jade hardware reference
>> platform with Ampere's Altra processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> drivers/mfd/Kconfig | 10 ++++++++++
>> drivers/mfd/simple-mfd-i2c.c | 15 +++++++++++++--
>> 2 files changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index b74efa469e90..5414371bdea1 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -77,6 +77,16 @@ config MFD_AS3711
>> help
>> Support for the AS3711 PMIC from AMS
>>
>> +config MFD_SMPRO
>> + tristate "Ampere Computing MFD SMpro core driver"
>> + select MFD_SIMPLE_MFD_I2C
>
> Nice to see another user here.
>
>> + help
>> + Say yes here to enable SMpro driver support for Ampere's Altra
>> + processor family.
>> +
>> + Ampere's Altra SMpro exposes an I2C regmap interface that can
>> + be accessed by child devices.
>> +
>> config MFD_AS3722
>> tristate "ams AS3722 Power Management IC"
>> select MFD_CORE
>> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
>> index 87f684cff9a1..0459a9fbd3f5 100644
>> --- a/drivers/mfd/simple-mfd-i2c.c
>> +++ b/drivers/mfd/simple-mfd-i2c.c
>> @@ -21,14 +21,24 @@ static const struct regmap_config simple_regmap_config = {
>> .val_bits = 8,
>> };
>>
>> +static const struct regmap_config simple_word_regmap_config = {
>> + .reg_bits = 8,
>> + .val_bits = 16,
>> +};
>> +
>> static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>> {
>> const struct regmap_config *config;
>> struct regmap *regmap;
>>
>> config = device_get_match_data(&i2c->dev);
>> - if (!config)
>> - config = &simple_regmap_config;
>> + if (!config) {
>> + if (of_device_is_compatible(i2c->dev.of_node,
>> + "ampere,ac01-smpro"))
>
> Could you use 'struct of_device_id's .data attribute instead please?
>
Thank you, but I'm not sure if I got it right.
Do you mean we could use .data attribute to get the expected
reg_bits/val_bits values and translate them to simple_word_regmap_config
without the need to match the compatible string ?
>> + config = &simple_word_regmap_config;
>> + else
>> + config = &simple_regmap_config;
>> + }
>>
>> regmap = devm_regmap_init_i2c(i2c, config);
>> if (IS_ERR(regmap))
>> @@ -39,6 +49,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>>
>> static const struct of_device_id simple_mfd_i2c_of_match[] = {
>> { .compatible = "kontron,sl28cpld" },
>> + { .compatible = "ampere,ac01-smpro" },
>> {}
>> };
>> MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
>
next prev parent reply other threads:[~2021-03-01 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 10:18 [PATCH 0/4] Add Ampere's Altra SMPro hwmon driver Quan Nguyen
2021-02-25 10:18 ` [PATCH 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers Quan Nguyen
2021-02-25 16:47 ` Guenter Roeck
2021-03-01 12:28 ` Quan Nguyen
2021-03-06 20:58 ` Rob Herring
2021-03-10 4:04 ` Quan Nguyen
2021-02-25 10:18 ` [PATCH 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support Quan Nguyen
2021-02-26 8:31 ` Lee Jones
2021-03-01 12:46 ` Quan Nguyen [this message]
2021-02-25 10:18 ` [PATCH 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-02-25 16:08 ` Guenter Roeck
2021-03-01 12:28 ` Quan Nguyen
2021-02-25 10:18 ` [PATCH 4/4] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2021-02-25 16:42 ` Guenter Roeck
2021-03-01 12:28 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b00f4c-6e6c-810d-d16d-5d01ebf4d36d@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).