From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918AFC4332F for ; Mon, 30 Oct 2023 19:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbjJ3Tfh (ORCPT ); Mon, 30 Oct 2023 15:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjJ3Tff (ORCPT ); Mon, 30 Oct 2023 15:35:35 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7C3DE4; Mon, 30 Oct 2023 12:35:32 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.24.143.101]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id EDAD36607391; Mon, 30 Oct 2023 19:35:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698694531; bh=WWn284JKSMebLrEmi0rI0JDzDGrgnLxf/WFScs6DuyY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CfD8pBzu37iX8/yO+b0ao9EJvGtfscPSiSQOwcP3nqk+yMSV9vlKt3zGk+C2br3Gg O4ZY4Y5ckxDY9aafrOXqfShO5Oxu8bovMEY/P1Xk/hwh9Gv5caQSPZJOzAPo9tlAvW u8r9Gu2w+qyiccFBm3LTYMXtD9zb79Aq19L6tAWy3APC0rKvj0CP6sePKOBUa3Rvhk z0ZsELzh6YGu/TK0TwM+HeBiTSVrDWmrMOGBlKbDfSFQJs3Yc+8zFQJ5B8viXU/Qno visBXDQVXdWw8d+A3yJZ8Dn8FMAduGJPAMztle+wARDTrROcd+4ucd8OEHsUSl3RzF uCyvLGfbRyQJQ== Message-ID: Date: Mon, 30 Oct 2023 21:35:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/12] dt-bindings: net: starfive,jh7110-dwmac: Drop redundant reset description Content-Language: en-US To: Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20231029042712.520010-1-cristian.ciocaltea@collabora.com> <20231029042712.520010-4-cristian.ciocaltea@collabora.com> <0ff7a905-d8f2-401b-a0ff-47947d12ce05@collabora.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/23 09:29, Krzysztof Kozlowski wrote: > On 29/10/2023 22:23, Cristian Ciocaltea wrote: >> On 10/29/23 13:19, Krzysztof Kozlowski wrote: >>> On 29/10/2023 05:27, Cristian Ciocaltea wrote: >>>> The reset description items are already provided by the referenced >>>> snps,dwmac.yaml schema, hence replace them with the necessary >>>> {min,max}Items. >>>> >>>> Signed-off-by: Cristian Ciocaltea >>>> --- >>>> .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++--- >>>> 1 file changed, 2 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> index cc3e1c6fc135..44e58755a5a2 100644 >>>> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> @@ -46,9 +46,8 @@ properties: >>>> maxItems: 3 >>>> >>>> resets: >>>> - items: >>>> - - description: MAC Reset signal. >>>> - - description: AHB Reset signal. >>>> + minItems: 2 >>>> + maxItems: 2 >>> >>> You must also update reset-names. They must have same constraints. >> >> reset-names explicitly lists the items and we need to keep them as such >> because the order is not fixed, i.e. PATCH 1 allows using 'ahb' instead >> of 'stmmaceth' as the first (and only) item. >> >> reset-names: >> items: >> - const: stmmaceth >> - const: ahb > > OK. Anyway this patch is no-op because next one removes this code. > Adding cleanup which is immediately removed does not make much sense. > Drop it. The next patch just moves that under an if clause. Regards, Cristian