From: Steen Hegelund <steen.hegelund@microchip.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Gregory Clement <gregory.clement@bootlin.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings
Date: Tue, 16 Feb 2021 09:32:28 +0100 [thread overview]
Message-ID: <f4d3c144326ce2984acfbc0e4b04c7f3edd6c4e8.camel@microchip.com> (raw)
In-Reply-To: <20210215173232.GM6798@piout.net>
Hi Alex,
On Mon, 2021-02-15 at 18:32 +0100, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On 10/02/2021 10:19:50+0100, Steen Hegelund wrote:
> > Document the Sparx5 reset device driver bindings
> >
> > The driver uses two IO ranges on sparx5 for access to
> > the reset control and the reset status.
> >
> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> > ---
> > .../bindings/reset/microchip,rst.yaml | 55
> > +++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/reset/microchip,rst.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > new file mode 100644
> > index 000000000000..80046172c9f8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/reset/microchip,rst.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Microchip Sparx5 Switch Reset Controller
> > +
> > +maintainers:
> > + - Steen Hegelund <steen.hegelund@microchip.com>
> > + - Lars Povlsen <lars.povlsen@microchip.com>
> > +
> > +description: |
> > + The Microchip Sparx5 Switch provides reset control and
> > implements the following
> > + functions
> > + - One Time Switch Core Reset (Soft Reset)
> > +
> > +properties:
> > + $nodename:
> > + pattern: "^reset-controller@[0-9a-f]+$"
> > +
> > + compatible:
> > + const: microchip,sparx5-switch-reset
> > +
> > + reg:
> > + items:
> > + - description: cpu block registers
> > + - description: global control block registers
> > +
> > + reg-names:
> > + items:
> > + - const: cpu
> > + - const: gcb
> > +
>
> I still think this is not right because then you will be mapping the
> same set of register using multiple drivers without any form of
> synchronisation which will work because you are mapping the region
> without requesting it. But this may lead to issues later.
>
> At least, you should make cpu start at 0x80 and of size 4. Else, you
> won't be able to define and use the GPRs that are in front of
> CPU_REGS:RESET.
>
> I would still keep DEVCPU_GCB:CHIP_REGS as a syscon, especially since
> you are mapping the whole set of registers.
Ok. I will use a syscon for the General Control Block and a very small
range for the CPU Reset register, to minimize the register footprint.
>
>
> > + "#reset-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - "#reset-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + reset: reset-controller@0 {
> > + compatible = "microchip,sparx5-switch-reset";
> > + #reset-cells = <1>;
> > + reg = <0x0 0xd0>,
> > + <0x11010000 0x10000>;
> > + reg-names = "cpu", "gcb";
> > + };
> > +
> > --
> > 2.30.0
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Thanks for your comments
--
BR
Steen
-=-=-=-=-=-=-=-=-=-=-=-=-=-=
steen.hegelund@microchip.com
next prev parent reply other threads:[~2021-02-16 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 9:19 [PATCH v5 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
2021-02-10 9:19 ` [PATCH v5 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund
2021-02-15 17:32 ` Alexandre Belloni
2021-02-16 8:32 ` Steen Hegelund [this message]
2021-02-10 9:19 ` [PATCH v5 2/3] reset: mchp: sparx5: add switch reset driver Steen Hegelund
2021-02-10 9:19 ` [PATCH v5 3/3] arm64: dts: reset: add microchip sparx5 " Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d3c144326ce2984acfbc0e4b04c7f3edd6c4e8.camel@microchip.com \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).