From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411EEC43463 for ; Fri, 18 Sep 2020 16:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 006062388E for ; Fri, 18 Sep 2020 16:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445165; bh=1pPWI3tGqdE3sjl7n8Nkm/Du5Ii/JiP1sJP58en8Fy8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=kLTIW+Odq3gLouPIRL9gCwgIhovQSWGoudbLUpKKzesuG+zMPeQsLhpjp58kfiBye +Bhe5JB2UfDmElK4Lh9TGiCW3Hke8UCmk2W0GFMOx8qBxcqvPJUUlB7KmiLemcj1GA MTEZyNn5x08ggKpvWfbBkRB8O/Dxqoa+aIw2vUd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726344AbgIRQGE (ORCPT ); Fri, 18 Sep 2020 12:06:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIRQGD (ORCPT ); Fri, 18 Sep 2020 12:06:03 -0400 Received: from [10.20.113.185] (unknown [12.97.180.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55424206A4; Fri, 18 Sep 2020 16:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600445163; bh=1pPWI3tGqdE3sjl7n8Nkm/Du5Ii/JiP1sJP58en8Fy8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=sMuOUFRpKhNx62cOeLq8r3XiweG3+oH+HQ5ARJFYrqRwI0rtwsXirIB8NlHDGu75P e/thqMV7HSpbh5YQpTfErTaxp2vvG3jgp5HhHsesYWxbd2rtaHY0RNKn6qtsVW1U4X 2OUqEA6d7Wt97I57tgwnc5CC2ttU5meMjx3RzqU0= Subject: Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver To: "Viorel Suman (OSS)" , Nicolin Chen Cc: Liam Girdwood , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai , Xiubo Li , Fabio Estevam , Shengjiu Wang , Philipp Zabel , Matthias Schiffer , Cosmin-Gabriel Samoila , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , dl-linux-imx , Viorel Suman References: <1600247876-8013-1-git-send-email-viorel.suman@oss.nxp.com> <1600247876-8013-2-git-send-email-viorel.suman@oss.nxp.com> <20200917071431.GA17970@Asurada-Nvidia> From: Timur Tabi Message-ID: Date: Fri, 18 Sep 2020 11:06:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/18/20 9:21 AM, Viorel Suman (OSS) wrote: >>> +static const u32 fsl_xcvr_earc_channels[] = { 1, 2, 8, 16, 32, }; /* >>> +one bit 6, 12 ? */ >> What's the meaning of the comments? > Just a thought noted as comment. HDMI2.1 spec defines 6- and 12-channels layout when > one bit audio stream is transmitted - I was wandering how can this be enforced. Is a @todo like of comment. Please don't add comments that other developers could never understand. The text that you just wrote here would be a great starting point for a better comment.