From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Laura Abbott <labbott@redhat.com>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Colin Cross <ccross@android.com>,
Jason Baron <jbaron@akamai.com>, Tony Luck <tony.luck@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Joe Perches <joe@perches.com>, Jim Cromie <jim.cromie@gmail.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Prasad Sodagudi <psodagud@codeaurora.org>,
tsoni@codeaurora.org, Bryan Huntsman <bryanh@codeaurora.org>,
Tingwei Zhang <tingwei@codeaurora.org>,
kernel-team <kernel-team@android.com>
Subject: Re: [PATCH 2/6] pstore: Add event tracing support
Date: Sat, 22 Sep 2018 23:15:53 +0530 [thread overview]
Message-ID: <f4d51d5a-fe1d-8697-6dc0-3ead7dc4ed6d@codeaurora.org> (raw)
In-Reply-To: <e8fdef37-afcd-24b3-1005-e707b73f20b1@codeaurora.org>
On 9/22/2018 10:07 PM, Sai Prakash Ranjan wrote:
> On 9/22/2018 2:35 PM, Joel Fernandes wrote:
>> On Sat, Sep 8, 2018 at 4:28 PM Sai Prakash Ranjan
>> <saiprakash.ranjan@codeaurora.org> wrote:
>
>
>> Also I think this spinlock can be moved further down.
>>
>
> OK. Something like this would suffice?
>
> {{{
> spin_lock_irqsave(&psinfo->buf_lock, flags);
>
> record.buf = (char *)(seq->buffer);
> record.size = seq->len;
> psinfo->write(&record);
>
> spin_unlock_irqrestore(&psinfo->buf_lock, flags);
> }}}
>
>
If I move the spinlock further down like above, I get this backtrace:
[ 1.367708] console [pstore-1] enabled
[ 1.368874] pstore: Registered ramoops as persistent store backend
[ 1.372637] ramoops: attached 0x100000@0xbff00000, ecc: 0/0
[ 1.389382] WARNING: CPU: 2 PID: 2 at kernel/trace/trace_output.c:289
trace_raw_output_prep+0x18/0xa0
[ 1.389416] Modules linked in:
[ 1.397572] CPU: 2 PID: 2 Comm: kthreadd Not tainted
4.19.0-rc4-00032-g71e30ed20433-dirty #9
[ 1.409122] pstate: 80000005 (Nzcv daif -PAN -UAO)
[ 1.415804] pc : trace_raw_output_prep+0x18/0xa0
[ 1.420404] lr : trace_raw_output_sched_process_fork+0x1c/0x70
[ 1.425176] sp : ffff00000803bc00
[ 1.430815] x29: ffff00000803bc00 x28: ffff80003ca68d80
[ 1.434204] x27: ffff00000810d000 x26: 0000000000000001
[ 1.439586] x25: 0000000000000000 x24: ffff80000eb05090
[ 1.444881] x23: ffff80003ca68d80 x22: ffff00000803bd58
[ 1.450176] x21: ffff000009e63000 x20: ffff80003cbf8988
[ 1.455470] x19: ffff80000eb04000 x18: ffffffffffffffff
[ 1.460766] x17: 000000000006df2c x16: 0000000000000000
[ 1.466061] x15: ffff000009b496c8 x14: 0000000000000040
[ 1.471356] x13: ffffffffffffffff x12: 0000000000000000
[ 1.476651] x11: ffff80003c49a6a8 x10: 00000000000005d8
[ 1.481947] x9 : ffff80003c89f400 x8 : ffff00000803bc60
[ 1.487242] x7 : 0000000000000034 x6 : 0000000005d97d4a
[ 1.492536] x5 : 00ffffffffffffff x4 : 0000000000000050
[ 1.497831] x3 : 0000000000000056 x2 : ffff000009b657a0
[ 1.503127] x1 : ffff000009b657c0 x0 : ffff80000eb04000
[ 1.508422] Call trace:
[ 1.513716] trace_raw_output_prep+0x18/0xa0
[ 1.515890] pstore_event_call+0xbc/0x130
[ 1.520402] trace_event_buffer_commit+0xf8/0x248
[ 1.524308] trace_event_raw_event_sched_process_fork+0xc0/0xf8
[ 1.528999] _do_fork+0x234/0x418
[ 1.534724] kernel_thread+0x48/0x58
[ 1.538196] kthreadd+0x178/0x1f0
[ 1.541842] ret_from_fork+0x10/0x1c
[ 1.545052] ---[ end trace 97d58905d13e7aea ]---
[ 1.560654] s1: supplied by regulator-dummy
[ 1.560714] s1: Bringing 0uV into 375000-375000uV
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-09-22 17:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 20:27 [PATCH 0/6] Tracing register accesses with pstore and dynamic debug Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 1/6] dt-bindings: ramoops: Add event-size property Sai Prakash Ranjan
[not found] ` <5b9f3f67.1c69fb81.3125b.c205@mx.google.com>
2018-09-17 17:15 ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 2/6] pstore: Add event tracing support Sai Prakash Ranjan
2018-09-11 10:46 ` Sai Prakash Ranjan
2018-09-17 17:38 ` Stephen Boyd
2018-09-17 19:43 ` Sai Prakash Ranjan
2018-09-16 7:07 ` Sai Prakash Ranjan
[not found] ` <CAEXW_YSPNqVgoYWjVAMvGg_WoRV4SC2xDH1wQWTdQfBUOMQbbQ@mail.gmail.com>
2018-09-17 14:54 ` Kees Cook
2018-09-17 17:17 ` Sai Prakash Ranjan
2018-09-17 17:13 ` Sai Prakash Ranjan
2018-09-17 23:04 ` Steven Rostedt
2018-09-18 6:24 ` Sai Prakash Ranjan
2018-09-17 23:34 ` Steven Rostedt
2018-09-18 17:52 ` Sai Prakash Ranjan
2018-09-18 20:44 ` Steven Rostedt
2018-09-18 21:13 ` Sai Prakash Ranjan
2018-09-22 6:48 ` Sai Prakash Ranjan
2018-09-22 9:05 ` Joel Fernandes
2018-09-22 16:37 ` Sai Prakash Ranjan
2018-09-22 17:32 ` Sai Prakash Ranjan
2018-09-22 17:45 ` Sai Prakash Ranjan [this message]
2018-09-23 15:33 ` Sai Prakash Ranjan
2018-09-25 20:37 ` Joel Fernandes
2018-09-25 20:39 ` Joel Fernandes
2018-09-25 20:40 ` Joel Fernandes
2018-09-26 9:52 ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 3/6] tracing: Add tp_pstore cmdline to have tracepoints go to pstore Sai Prakash Ranjan
2018-09-25 21:25 ` Joel Fernandes
2018-09-26 9:46 ` Sai Prakash Ranjan
2018-10-08 14:16 ` Sai Prakash Ranjan
2018-10-08 14:36 ` Steven Rostedt
2018-10-08 22:40 ` Joel Fernandes
2018-10-09 18:22 ` Sai Prakash Ranjan
2018-10-10 19:37 ` Steven Rostedt
2018-09-08 20:27 ` [PATCH 4/6] arm64/io: Add tracepoint for register accesses Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 5/6] arm64/io: Add header for instrumentation of io operations Sai Prakash Ranjan
2018-09-17 23:39 ` Steven Rostedt
2018-09-18 7:10 ` Sai Prakash Ranjan
2018-09-18 11:47 ` Will Deacon
2018-09-18 12:43 ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 6/6] dynamic_debug: Add flag for dynamic event tracing Sai Prakash Ranjan
2018-09-11 15:11 ` [PATCH 0/6] Tracing register accesses with pstore and dynamic debug Will Deacon
2018-09-11 16:11 ` Sai Prakash Ranjan
2018-10-20 5:25 ` Joel Fernandes
2018-10-20 6:32 ` Sai Prakash Ranjan
2018-10-20 16:27 ` Joel Fernandes
2018-10-21 3:46 ` Sai Prakash Ranjan
2018-10-21 4:59 ` Sai Prakash Ranjan
2018-10-21 5:09 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d51d5a-fe1d-8697-6dc0-3ead7dc4ed6d@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=psodagud@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sibis@codeaurora.org \
--cc=tingwei@codeaurora.org \
--cc=tom.zanussi@linux.intel.com \
--cc=tony.luck@intel.com \
--cc=tsoni@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).