From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA34C432BE for ; Mon, 26 Jul 2021 22:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC35D60F94 for ; Mon, 26 Jul 2021 22:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbhGZVmb (ORCPT ); Mon, 26 Jul 2021 17:42:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21545 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbhGZVm3 (ORCPT ); Mon, 26 Jul 2021 17:42:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627338177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q9dAuuhQeXJnHY9YOxmU0U5Agmhqw2dB6e5Zy44E0hE=; b=jICSysVYGOpqUKNL/UcgbjYUVCcYeuCSq7QPUzUG3QTboykUgU6+8/wE7EVot3sQ8K6IKV ylFu4lSHmLShEncwY6pcT9/Bnsor8dRne0qjtjatgrL+foQh3LWjP0e/96akcSbweN1P5o 2aY+2pzqEG4oJqJW+omIC6VWcHLBqvM= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-tShSUE-jNAW4OToPzgWVuA-1; Mon, 26 Jul 2021 18:22:55 -0400 X-MC-Unique: tShSUE-jNAW4OToPzgWVuA-1 Received: by mail-ej1-f70.google.com with SMTP id x5-20020a1709064bc5b02905305454f5d1so2500257ejv.10 for ; Mon, 26 Jul 2021 15:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q9dAuuhQeXJnHY9YOxmU0U5Agmhqw2dB6e5Zy44E0hE=; b=fCHHpVc19XcqQ29At4YvSld9O3+vnuo8Q4HF80V5hPxjF1sG2zJLiTOSihqRRN7L3m ARPulk8MhJ6qlg+DfaFm93V4m/NUhOKuJklE+0mt/A+wN9Me2l2Ya0Buk0dbQ7BVNGye +7UUNXtvujMKq3hzLNPLxOw8FySjYpjuVOijyDuL9l21hzCYaLHwilCcq7/hnI3CcaKE IYipfLMIm/aWXgApAEwaRUWq7NkTmyMkr5EQH1jA1NnwIibbn9mU8Mz9XYlvQWMFy6Ah UnORv5ne7rpdDg3LnNBuGSt6dhzZ9u9PPe1VknS3Z2Ly/H2qQUFHT3gMZi8351MWfWrg 5d3A== X-Gm-Message-State: AOAM53356czewJl31KhYgRF+JMb64MOD5ibxv/Em4+fL3CzA1BNBXfVz rqa/ARkkfkiyFCFxKn/EBecNTzTAgrtGBekmxQIbf5gtY7alkFPeFYOd615MZcExX0x6UWmWlSA ukdokCbPs6vbPpJ2wdrvktGvZ X-Received: by 2002:a17:906:4f01:: with SMTP id t1mr10810089eju.388.1627338174804; Mon, 26 Jul 2021 15:22:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl1rSXlpY7vfcBbP4lSuX0aLNAwNQhSLeSGAi2brZYkcDm0gFPy32/jKoIa+cofv3hQjwuLA== X-Received: by 2002:a17:906:4f01:: with SMTP id t1mr10810071eju.388.1627338174573; Mon, 26 Jul 2021 15:22:54 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id l7sm284712ejk.53.2021.07.26.15.22.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 15:22:53 -0700 (PDT) Subject: Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Reiji Watanabe References: <20210713163324.627647-1-seanjc@google.com> <20210713163324.627647-42-seanjc@google.com> <7ddb5bfb-f274-9867-3efb-0b6ba5224aa2@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 27 Jul 2021 00:22:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/21 00:21, Sean Christopherson wrote: > On Mon, Jul 26, 2021, Paolo Bonzini wrote: >> On 13/07/21 18:33, Sean Christopherson wrote: >>> + if (!(mode ^ vmx->x2apic_msr_bitmap_mode)) >>> + return; >> Just !=, I guess? > Ha, yeah. Forgot to do a bit of critical thinking after refactoring. > Well, == even since I assume you don't want the ! in front. :) Paolo