From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 1/2] memory: tegra: Add missing dependencies
Date: Fri, 11 Jun 2021 10:21:41 +0300 [thread overview]
Message-ID: <f5112945-1b07-8760-4180-4d7152b7dcba@gmail.com> (raw)
In-Reply-To: <99f98088-fed4-45bf-b0a1-241bfc896487@canonical.com>
11.06.2021 09:50, Krzysztof Kozlowski пишет:
> On 10/06/2021 18:23, Dmitry Osipenko wrote:
>> 10.06.2021 18:50, Dmitry Osipenko пишет:
>>> 10.06.2021 09:43, Krzysztof Kozlowski пишет:
>>>> The stubs might be good idea anyway, but the driver explicitly needs for
>>>> runtime working reservedmem, so it should select it.
>>>
>>> The OF and reservedmem are both selected by the ARCH for the runtime
>>> use. They may not be selected in the case of compile-testing.
>>>
>>> Both OF core and reservedmem provide stubs needed for compile-testing,
>>> it's only the RESERVEDMEM_OF_DECLARE() that is missing the stub. Adding
>>> the missing stub should be a more appropriate solution than adding extra
>>> Kconfig dependencies, IMO.
>
> Ah, in such case everything looks good. Stubs is indeed proper choice.
Although, I see that there are only two Kconfigs that have
OF_RESERVED_MEM, one defines the OF_RESERVED_MEM, the other is QCOM
Kconfig which depends on OF_RESERVED_MEM. The OF_RESERVED_MEM is enabled
by default in defconfig.
You're right, we need the Kconfig change to be entirely correct, since
driver won't work properly without OF_RESERVED_MEM.
config TEGRA210_EMC
tristate "NVIDIA Tegra210 External Memory Controller driver"
- depends on ARCH_TEGRA_210_SOC || COMPILE_TEST
+ depends on (ARCH_TEGRA_210_SOC && OF_RESERVED_MEM) || COMPILE_TEST
I will send that change later today.
next prev parent reply other threads:[~2021-06-11 7:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:28 [PATCH 0/2] memory: tegra: Fixes for COMPILE_TEST Thierry Reding
2021-06-09 11:28 ` [PATCH 1/2] memory: tegra: Add missing dependencies Thierry Reding
2021-06-09 11:58 ` Dmitry Osipenko
2021-06-09 13:19 ` Krzysztof Kozlowski
2021-06-09 16:57 ` Dmitry Osipenko
2021-06-10 6:43 ` Krzysztof Kozlowski
2021-06-10 15:50 ` Dmitry Osipenko
2021-06-10 16:23 ` Dmitry Osipenko
2021-06-11 6:50 ` Krzysztof Kozlowski
2021-06-11 7:21 ` Dmitry Osipenko [this message]
2021-06-11 11:00 ` Thierry Reding
2021-06-11 13:40 ` Dmitry Osipenko
2021-06-14 11:50 ` Krzysztof Kozlowski
2021-06-14 14:16 ` Dmitry Osipenko
2021-06-09 17:00 ` Thierry Reding
2021-06-10 6:42 ` Krzysztof Kozlowski
2021-06-17 0:35 ` kernel test robot
2021-06-09 11:28 ` [PATCH 2/2] reset: Add compile-test stubs Thierry Reding
2021-06-09 11:47 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5112945-1b07-8760-4180-4d7152b7dcba@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).