linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nishad Kamdar <nishadkamdar@gmail.com>,
	Lidza Louina <lidza.louina@gmail.com>,
	Mark Hounschell <markh@compro.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line
Date: Sun, 22 Jul 2018 00:50:25 -0700	[thread overview]
Message-ID: <f512941f3dba2b5f3bf3434bb2b0b4b1602c5122.camel@perches.com> (raw)
In-Reply-To: <20180722040912.GA18833@nishad>

On Sun, 2018-07-22 at 09:39 +0530, Nishad Kamdar wrote:
> Bring the first argument to the previous line and
> align the other lines to match open parenthesis.
[]
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
[]
> @@ -883,10 +883,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
>  	 * touched safely, the close routine will signal the
>  	 * ch_flags_wait to wake us back up.
>  	 */
> -	rc = wait_event_interruptible(
> -				ch->ch_flags_wait,
> -				(((ch->ch_tun.un_flags |
> -				ch->ch_pun.un_flags) & UN_CLOSING) == 0));
> +	rc = wait_event_interruptible(ch->ch_flags_wait,
> +				      (((ch->ch_tun.un_flags |
> +				      ch->ch_pun.un_flags) & UN_CLOSING) == 0));


This would be better without the superfluous () and perhaps use !

	rc = wait_event_interruptible(ch->ch_flags_wait,
				      !((ch->ch_tun.un_flags |
					 ch->ch_pun.un_flags) & UN_CLOSING));



  reply	other threads:[~2018-07-22  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-22  4:09 [PATCH] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line Nishad Kamdar
2018-07-22  7:50 ` Joe Perches [this message]
2018-07-22 17:16   ` Nishad Kamdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f512941f3dba2b5f3bf3434bb2b0b4b1602c5122.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=nishadkamdar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).