From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F64C43461 for ; Fri, 4 Sep 2020 10:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E426D206D4 for ; Fri, 4 Sep 2020 10:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbgIDKFd (ORCPT ); Fri, 4 Sep 2020 06:05:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52162 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726811AbgIDKFa (ORCPT ); Fri, 4 Sep 2020 06:05:30 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-rc5grr6gOyq25YEngeUmUg-1; Fri, 04 Sep 2020 06:05:27 -0400 X-MC-Unique: rc5grr6gOyq25YEngeUmUg-1 Received: by mail-ed1-f71.google.com with SMTP id y21so2460513edu.23 for ; Fri, 04 Sep 2020 03:05:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cMyogM8ZaAuNV7IxlLfX+jXiTjjJ4VPOtsKDCg2OR6A=; b=KnTos83OTWu6m+m8+sH70Mof8n+VX9HZLGuuJianOD0EzArTRmSNuOdNLBnqnNIe5r UL2ToTF31kwI463Kvs44YtvhBxy6PcihNSsQIGRoEANa/CNj/bbyuHbGW18+tI7Pqmk3 0inRMevVnSh5Eerg+D6l8FcJEzh1E6w7rRtoFtteQfYIbzstPaeGHpv4PiHDayDOKcwB LWw/g9wvLw7cWevOQ+L8EQMPlwTJ4xd3BowvOmr7X9hR6AayKEEQOdUQzX2vQ/SLlfbg heKsQBkhaRaz1dlkfYCskmGNHEcEz/FbCtZWmCjz593jI0237b7vVg2nIBBg6QQvhgEO G+cw== X-Gm-Message-State: AOAM531T9lx3W+LlJA2QjcpFhq/Klu6uUZsRGvklKOiuVQ6Y5+BIkVfm uSaqKoXyopYpFdaxcW3ggEbocEP8pan+z8V6i82GEVH/+Q9WHCuHrTCKQHDodmvDTQXpXwe8alW lApzUEvr/scQrnOZp9iKljOCO X-Received: by 2002:a17:906:6805:: with SMTP id k5mr6211703ejr.397.1599213925728; Fri, 04 Sep 2020 03:05:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6nPPe8mUMfr66/fT4ciZ4Zhe4GtwODi5MgFU85csrnkDnHN8nJsAEcKFSHNX1KN2Z4xR87Q== X-Received: by 2002:a17:906:6805:: with SMTP id k5mr6211680ejr.397.1599213925469; Fri, 04 Sep 2020 03:05:25 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id x1sm5595434ejc.119.2020.09.04.03.05.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2020 03:05:24 -0700 (PDT) Subject: Re: [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook To: Penghao , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: johan@kernel.org, dlaz@chromium.org, stern@rowland.harvard.edu, kerneldev@karsmulder.nl, jonathan@jdcox.net, tomasz@meresinski.eu References: <20200904091322.30426-1-penghao@uniontech.com> From: Hans de Goede Message-ID: Date: Fri, 4 Sep 2020 12:05:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200904091322.30426-1-penghao@uniontech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/4/20 11:13 AM, Penghao wrote: > Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook. > This notebook come with usb touchpad. And we would like to disable touchpad > wakeup on this notebook by default. You are still not explaining why this is necessary ? And you did not answer my question if this touchpad is using hid-multitouch either ? So NACK (rejection) from me until both questions are answered. The commi message for a quirk should always explain why a quirk is necessary and "we would like to disable touchpad wakeup on this notebook by default" does not explain why you want to do that. Regards, Hans > > Signed-off-by: Penghao > --- > > Changes since v2: > - Add changes > > Changes since v1: > - Add the entries sorted by vendor ID and product ID. > > drivers/usb/core/quirks.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 7c1198f80c23..fffe1f7f1098 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -393,6 +393,10 @@ static const struct usb_device_id usb_quirk_list[] = { > /* Generic RTL8153 based ethernet adapters */ > { USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM }, > > + /* SONiX USB DEVICE Touchpad */ > + { USB_DEVICE(0x0c45, 0x7056), .driver_info = > + USB_QUIRK_IGNORE_REMOTE_WAKEUP }, > + > /* Action Semiconductor flash disk */ > { USB_DEVICE(0x10d6, 0x2200), .driver_info = > USB_QUIRK_STRING_FETCH_255 }, >