linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: asmadeus@codewreck.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>, Arnd Bergmann <arnd@arndb.de>,
	dwmw@amazon.co.uk, LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	daniel@iogearbox.net, hpa@zytor.com
Subject: Re: [PATCH] compiler-gcc: get back Clang build
Date: Wed, 22 Aug 2018 16:32:09 -0700	[thread overview]
Message-ID: <f51e6c2dcd83aae2af8d9e1d0b40e76e6c680446.camel@perches.com> (raw)
In-Reply-To: <CAKwvOdmZuzhyaOzh_ruNQUp96zed8+BAz3DCw1hrZrseVNg9tA@mail.gmail.com>

On Wed, 2018-08-22 at 16:05 -0700, Nick Desaulniers wrote:

Hey Nick.

> On Wed, Aug 22, 2018 at 1:50 PM Joe Perches <joe@perches.com> wrote:
> > A mild suggestion about the patch would be to break it up into
> > 2 patches to improve how people read and review them.
> > 
> > 1 include/linux/compiler-*
> > 2 everything else
> > 
> > Yes, some kernel configs might not build properly between 1 and 2
> > but that likely doesn't matter as those configs probably don't
> > build before 1 either.
> 
> If we ordered the patches so that the "everything else" went in first,
> it would not be a problem.  The first patch would just be the checks
> that GCC_VERSION is defined.
> 
> In general, I'm happy to split patches, but in this suggested case, it
> only shaves off 26 lines from the main body of work.

No worries, I rarely care _that_ much about code, but
seeing the subject with compiler-gcc and the first
part of the patch about arch/ was a bit off-putting.

You're the one doing the work here.
Do what you think best.


  reply	other threads:[~2018-08-22 23:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21  6:48 [PATCH] compiler-gcc: get back Clang build Masahiro Yamada
2018-08-21  8:09 ` Nick Desaulniers
2018-08-21 10:39 ` Joe Perches
2018-08-21 16:35   ` Nick Desaulniers
2018-08-21 17:13   ` Masahiro Yamada
2018-08-21 17:20     ` Joe Perches
2018-08-21 12:38 ` Dominique Martinet
2018-08-21 16:32   ` Nick Desaulniers
2018-08-21 16:45     ` Joe Perches
2018-08-21 17:00       ` Nick Desaulniers
2018-08-22  4:16         ` Dominique Martinet
2018-08-22  4:22           ` Joe Perches
2018-08-22  4:32             ` Dominique Martinet
2018-08-22 18:31               ` Nick Desaulniers
2018-08-22 19:01                 ` Nick Desaulniers
2018-08-22 20:50                 ` Joe Perches
2018-08-22 23:05                   ` Nick Desaulniers
2018-08-22 23:32                     ` Joe Perches [this message]
2018-08-22 23:57                 ` Dominique Martinet
2018-08-21 16:33 ` Joe Perches
2018-08-21 16:57   ` Nick Desaulniers
2018-08-21 17:22     ` Joe Perches
2018-08-21 17:07   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f51e6c2dcd83aae2af8d9e1d0b40e76e6c680446.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=asmadeus@codewreck.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=dwmw@amazon.co.uk \
    --cc=geert@linux-m68k.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).