From: Shuah Khan <shuah@kernel.org>
To: Laura Abbott <labbott@redhat.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Todd Kjos <tkjos@android.com>,
dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Liam Mark <lmark@codeaurora.org>,
linux-kselftest@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/2] selftests: ion: Remove some prints
Date: Mon, 26 Feb 2018 09:54:37 -0700 [thread overview]
Message-ID: <f5324fa1-64fe-4b22-944b-c646c662a48f@kernel.org> (raw)
In-Reply-To: <20180216012445.17264-2-labbott@redhat.com>
On 02/15/2018 06:24 PM, Laura Abbott wrote:
> There's no need to print messages each time we alloc and free. Remove them.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> tools/testing/selftests/android/ion/ionutils.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c
> index ce69c14f51fa..7d1d37c4ef6a 100644
> --- a/tools/testing/selftests/android/ion/ionutils.c
> +++ b/tools/testing/selftests/android/ion/ionutils.c
> @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info)
> heap_id = MAX_HEAP_COUNT + 1;
> for (i = 0; i < query.cnt; i++) {
> if (heap_data[i].type == ion_info->heap_type) {
> - printf("--------------------------------------\n");
> - printf("heap type: %d\n", heap_data[i].type);
> - printf(" heap id: %d\n", heap_data[i].heap_id);
> - printf("heap name: %s\n", heap_data[i].name);
> - printf("--------------------------------------\n");
> heap_id = heap_data[i].heap_id;
> break;
> }
> @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info)
> /* Finally, close the client fd */
> if (ion_info->ionfd > 0)
> close(ion_info->ionfd);
> - printf("<%s>: buffer release successfully....\n", __func__);
> }
> }
>
>
Thanks Laura. I will queue this up for 4.17-rc1.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-02-26 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 1:24 [RFC PATCH 0/2] Ion unit test with VGEM Laura Abbott
2018-02-16 1:24 ` [PATCH 1/2] selftests: ion: Remove some prints Laura Abbott
2018-02-26 16:54 ` Shuah Khan [this message]
2018-02-16 1:24 ` [PATCH 2/2] selftests: ion: Add simple test with the vgem driver Laura Abbott
2018-02-19 15:31 ` Daniel Vetter
2018-02-19 18:18 ` Laura Abbott
2018-02-19 18:33 ` Daniel Vetter
2018-02-26 17:07 ` Shuah Khan
2018-02-27 1:48 ` Laura Abbott
2018-02-27 15:06 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5324fa1-64fe-4b22-944b-c646c662a48f@kernel.org \
--to=shuah@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=shuahkh@osg.samsung.com \
--cc=sumit.semwal@linaro.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).