From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CACEC433E6 for ; Wed, 6 Jan 2021 09:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3E7B2311D for ; Wed, 6 Jan 2021 09:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbhAFJ4A (ORCPT ); Wed, 6 Jan 2021 04:56:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbhAFJz7 (ORCPT ); Wed, 6 Jan 2021 04:55:59 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94141C06134C for ; Wed, 6 Jan 2021 01:55:18 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kx5X9-00Bvk3-Ip for linux-kernel@vger.kernel.org; Wed, 06 Jan 2021 10:55:15 +0100 Received: from [85.234.217.28] (helo=[10.0.1.5]) by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kx5Wp-00BvjI-AB; Wed, 06 Jan 2021 10:54:55 +0100 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support To: Rob Herring Cc: devicetree@vger.kernel.org, John Crispin , Marc Zyngier , linux-kernel@vger.kernel.org, Birger Koblitz , Thomas Gleixner , Rob Herring References: <20210104131755.2979203-1-bert@biot.com> <20210104131755.2979203-2-bert@biot.com> <1609866288.019144.372417.nullmailer@robh.at.kernel.org> From: Bert Vermeulen Message-ID: Date: Wed, 6 Jan 2021 10:54:54 +0100 MIME-Version: 1.0 In-Reply-To: <1609866288.019144.372417.nullmailer@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 6:04 PM, Rob Herring wrote: > On Mon, 04 Jan 2021 14:17:54 +0100, Bert Vermeulen wrote: >> Signed-off-by: Bert Vermeulen >> --- >> .../realtek,rtl-intc.yaml | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: I fixed the syntax error that caused this to fail. But running the test now produces some errors that are not so obvious: interrupt-controller@3000: interrupt-map: [[31, 4294967295, 2], [30, 4294967295, 1], [29, 4294967295, 5]] is too short Not sure where this comes from, but running dt-validate -v gives this: Failed validating 'minItems' in schema['properties']['interrupt-map']: {'maxItems': 24, 'minItems': 24} Where did that 24 come from? I don't even have 24 initerrupts to map :-) Another error is this: interrupt-controller@3000: 'interrupt-map-mask' is a dependency of 'interrupt-map' I can see this in your dtschema package's schemas/interrupt-controller.yaml where it's defined as a dependency, but why? I don't need that property. -- Bert Vermeulen bert@biot.com