From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] forbid fix {SQ,IO}POLL
Date: Thu, 4 Jun 2020 11:06:10 -0600 [thread overview]
Message-ID: <f5370eb3-af80-5481-3589-675befa41009@kernel.dk> (raw)
In-Reply-To: <414b9a24-2e70-3637-0b98-10adf3636c37@kernel.dk>
On 6/3/20 12:51 PM, Jens Axboe wrote:
> On 6/3/20 9:03 AM, Pavel Begunkov wrote:
>> The first one adds checks {SQPOLL,IOPOLL}. IOPOLL check can be
>> moved in the common path later, or rethinked entirely, e.g.
>> not io_iopoll_req_issued()'ed for unsupported opcodes.
>>
>> 3 others are just cleanups on top.
>>
>>
>> v2: add IOPOLL to the whole bunch of opcodes in [1/4].
>> dirty and effective.
>> v3: sent wrong set in v2, re-sending right one
>>
>> Pavel Begunkov (4):
>> io_uring: fix {SQ,IO}POLL with unsupported opcodes
>> io_uring: do build_open_how() only once
>> io_uring: deduplicate io_openat{,2}_prep()
>> io_uring: move send/recv IOPOLL check into prep
>>
>> fs/io_uring.c | 94 ++++++++++++++++++++++++++-------------------------
>> 1 file changed, 48 insertions(+), 46 deletions(-)
>
> Thanks, applied.
#1 goes too far, provide/remove buffers is fine with iopoll. I'll
going to edit the patch.
--
Jens Axboe
next prev parent reply other threads:[~2020-06-04 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 15:03 [PATCH v3 0/4] forbid fix {SQ,IO}POLL Pavel Begunkov
2020-06-03 15:03 ` [PATCH v3 1/4] io_uring: fix {SQ,IO}POLL with unsupported opcodes Pavel Begunkov
2020-06-03 15:03 ` [PATCH v3 2/4] io_uring: do build_open_how() only once Pavel Begunkov
2020-06-03 15:03 ` [PATCH v3 3/4] io_uring: deduplicate io_openat{,2}_prep() Pavel Begunkov
2020-06-03 15:03 ` [PATCH v3 4/4] io_uring: move send/recv IOPOLL check into prep Pavel Begunkov
2020-06-03 15:14 ` [PATCH v3 0/4] forbid fix {SQ,IO}POLL Pavel Begunkov
2020-06-03 18:51 ` Jens Axboe
2020-06-04 17:06 ` Jens Axboe [this message]
2020-06-04 19:22 ` Pavel Begunkov
2020-06-04 19:52 ` Jens Axboe
2020-06-04 20:12 ` Pavel Begunkov
2020-06-04 20:17 ` Jens Axboe
2020-06-04 20:25 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5370eb3-af80-5481-3589-675befa41009@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).