From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFA4C43461 for ; Tue, 18 May 2021 22:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A1FD6135F for ; Tue, 18 May 2021 22:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352673AbhERWCR (ORCPT ); Tue, 18 May 2021 18:02:17 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:28373 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236677AbhERWCP (ORCPT ); Tue, 18 May 2021 18:02:15 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621375257; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=OcOBQoPHRZwUqgAv23Az6sbpsFYYr9MWtPojMc2GtPo=; b=IIsmxq3E8fvTebWmAMcKiMuYMH/RBu45Dt8awhU5Om2q2QrCx1LuNJgvfXoOpibNLbgsmjHs N/YXT5hLoyLz/94R4c7KUDIthTFerV3hpw1FmfMqt4Bc59JR3u/+rUJ3hxbB5WTxtzkcF3Oy zN+MT4z4dLaObzb3R9183zPoRI8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 60a4390d8dd30e785f852f6c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 18 May 2021 22:00:45 GMT Sender: jjohnson=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E7AFEC4338A; Tue, 18 May 2021 22:00:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jjohnson) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5FB86C433D3; Tue, 18 May 2021 22:00:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 18 May 2021 15:00:44 -0700 From: Jeff Johnson To: Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org, Kalle Valo , "David S. Miller" , Jakub Kicinski , Kees Cook , Jason Gunthorpe , Chao Yu , Leon Romanovsky , b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jjohnson=codeaurora.org@codeaurora.org Subject: Re: [PATCH v2] b43: don't save dentries for debugfs In-Reply-To: <891f28e4c1f3c24ed1b257de83cbb3a0@codeaurora.org> References: <20210518163304.3702015-1-gregkh@linuxfoundation.org> <891f28e4c1f3c24ed1b257de83cbb3a0@codeaurora.org> Message-ID: X-Sender: jjohnson@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-05-18 12:29, Jeff Johnson wrote: > On 2021-05-18 09:33, Greg Kroah-Hartman wrote: >> There is no need to keep around the dentry pointers for the debugfs >> files as they will all be automatically removed when the subdir is >> removed. So save the space and logic involved in keeping them around >> by >> just getting rid of them entirely. >> >> By doing this change, we remove one of the last in-kernel user that >> was >> storing the result of debugfs_create_bool(), so that api can be >> cleaned >> up. > > Question not about this specific change, but the general concept > of keeping (or not keeping) dentry pointers. In the ath drivers, > as well as in an out-of-tree driver for Android, we keep a > debugfs dentry pointer to use as a param to relay_open(). > > Will we still be able to have a dentry pointer for this purpose? > Or better, is there a recommended way to get a dentry pointer > NOT associated with debugfs at all (which would be ideal for > Android where debugfs is disabled). Answering one of my questions: The dentry passed to relay_open() comes from debugfs_create_dir() which is expected to return a dentry. Would still like guidance on if there is a recommended way to get a dentry not associated with debugfs. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project