From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB66C433E0 for ; Wed, 8 Jul 2020 06:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BD9320786 for ; Wed, 8 Jul 2020 06:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728738AbgGHGKZ (ORCPT ); Wed, 8 Jul 2020 02:10:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:52422 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbgGHGKZ (ORCPT ); Wed, 8 Jul 2020 02:10:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D914DAC85; Wed, 8 Jul 2020 06:10:23 +0000 (UTC) Subject: Re: [PATCH 3/4] drm: edid: Convert logging to drm_* functions. To: Suraj Upadhyay , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: From: Thomas Zimmermann Message-ID: Date: Wed, 8 Jul 2020 08:10:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Aj1qZ3yM9HNG73TZ3TVu4EOJ0Q3Iy8LMy" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Aj1qZ3yM9HNG73TZ3TVu4EOJ0Q3Iy8LMy Content-Type: multipart/mixed; boundary="KjxtwsAfKUN6yuas7AqYIusFYNmrJoZhR"; protected-headers="v1" From: Thomas Zimmermann To: Suraj Upadhyay , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH 3/4] drm: edid: Convert logging to drm_* functions. References: In-Reply-To: --KjxtwsAfKUN6yuas7AqYIusFYNmrJoZhR Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Thanks! Am 07.07.20 um 18:36 schrieb Suraj Upadhyay: > Change logging of warnings to drm_warn() form dev_warn(). >=20 > Signed-off-by: Suraj Upadhyay Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_edid.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 31496b6cfc56..ad7a1f9817ed 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1844,9 +1844,8 @@ static void connector_bad_edid(struct drm_connect= or *connector, > if (connector->bad_edid_counter++ && !drm_debug_enabled(DRM_UT_KMS)) > return; > =20 > - dev_warn(connector->dev->dev, > - "%s: EDID is invalid:\n", > - connector->name); > + drm_warn(connector->dev, "%s: EDID is invalid:\n", connector->name); > + > for (i =3D 0; i < num_blocks; i++) { > u8 *block =3D edid + i * EDID_LENGTH; > char prefix[20]; > @@ -5284,7 +5283,7 @@ int drm_add_edid_modes(struct drm_connector *conn= ector, struct edid *edid) > } > if (!drm_edid_is_valid(edid)) { > clear_eld(connector); > - dev_warn(connector->dev->dev, "%s: EDID invalid.\n", > + drm_warn(connector->dev, "%s: EDID invalid.\n", > connector->name); > return 0; > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=FCrnberg, Germany (HRB 36809, AG N=FCrnberg) Gesch=E4ftsf=FChrer: Felix Imend=F6rffer --KjxtwsAfKUN6yuas7AqYIusFYNmrJoZhR-- --Aj1qZ3yM9HNG73TZ3TVu4EOJ0Q3Iy8LMy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl8FY04UHHR6aW1tZXJt YW5uQHN1c2UuZGUACgkQaA3BHVMLeiOTVwgAlzwaXOm530Y6ErmMjccFyJqGt84t Vu0pYsJ3Fp1Pv4DLg2hQmSYD4OXDnqLHS/lqypMx9iVYLqNCFpDdwx7w0Ic0I1Jd 6y6OW1JTXarO7x6jFni3dtLOglALlAEpPZeu0Q6sAeAyodxfgdbNtW1ydNLOmB6r 8YYa8Zo2lnfIRU4Q/s2zv6a1PfQIPIHhRTIrHwmHqTn6AmwO0amNwgrKF4oFIBmz Y8TYE6yMgwOF1X8rAFNDkgzLMdaSroxvwzWfWWp3xG+fFTsUGAMDmoBEkZ4e68Be 7JfYdobM2SVLMOn5lDvQEzNjFV4p8QNaevKI4DZCYrXFpiEbaRE1ELgFWw== =65eH -----END PGP SIGNATURE----- --Aj1qZ3yM9HNG73TZ3TVu4EOJ0Q3Iy8LMy--