From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AE0C7EE23 for ; Wed, 3 May 2023 12:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbjECMMH (ORCPT ); Wed, 3 May 2023 08:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjECMME (ORCPT ); Wed, 3 May 2023 08:12:04 -0400 X-Greylist: delayed 595 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 03 May 2023 05:11:59 PDT Received: from proxima.lasnet.de (proxima.lasnet.de [IPv6:2a01:4f8:121:31eb:3::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E4451BFC; Wed, 3 May 2023 05:11:59 -0700 (PDT) Received: from [IPV6:2003:e9:d706:54a1:212b:c98b:d0c5:6c8c] (p200300e9d70654a1212bc98bd0c56c8c.dip0.t-ipconnect.de [IPv6:2003:e9:d706:54a1:212b:c98b:d0c5:6c8c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id 82FFAC00AF; Wed, 3 May 2023 14:01:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenfreihafen.org; s=2021; t=1683115319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jrY4np7MIEvKj3oth8g3qje83iXw5OFsZNJLsl8D7RQ=; b=uKEEkxzo4jZwwNqIjEPvwkWPHWvKHNyQL62sEHhuw8fTrst//3B4Jz7HPuLZ53cgZo8hzu kFT/KmpufWXNCH4OBKVSVBmBQ49Qt0/qnrmzQztaS0cVHrus38DsOwEkS87hsxtmyNtfdG rC03XUGSYEuo3/K+v8eMwq/i3AnFp0KnqeNsvEWkx0Y54BpS7SeltuaO3OyqIdCoh9wRFB pIx2GdUF2Ki/lnEcCfgOEwoXHdqHG472NOA0DccePOmMj7wshaWu4qMMavnYPVt84aAd4y m+qamR0+DUqmfDd2dAvYAAfLpj8uMGyepMzm6DNtwNX3r5ahAGzJKgzG71PkoQ== Message-ID: Date: Wed, 3 May 2023 14:01:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] ca8210: move to gpio descriptors Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , Alexander Aring Cc: "open list:GPIO SUBSYSTEM" , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , linux-wpan@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org References: <20230126161737.2985704-1-arnd@kernel.org> <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com> From: Stefan Schmidt In-Reply-To: <57e74219-d439-4d10-9bb5-53fe7b30b46f@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd. On 26.01.23 17:25, Arnd Bergmann wrote: > On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote: > >> if (ret) { >> - dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); >> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); >> - gpio_free(pdata->gpio_irq); >> + dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id); >> + gpiod_put(priv->gpio_irq); >> } > > I just realized that this bit depends on the "gpiolib: remove > legacy gpio_export" patch I sent to the gpio mailing list earlier. > > We can probably just defer this change until that is merged, > or alternatively I can rebase this patch to avoid the > dependency. I think the gpiolib ependency should be merged now. Do you want to rebase this patch against latest? We had some other ca8210 changes coming in. regards Stefan Schmidt