From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F091C43214 for ; Thu, 2 Sep 2021 10:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E9F60F91 for ; Thu, 2 Sep 2021 10:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237077AbhIBKze (ORCPT ); Thu, 2 Sep 2021 06:55:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242730AbhIBKzc (ORCPT ); Thu, 2 Sep 2021 06:55:32 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E480C061757; Thu, 2 Sep 2021 03:54:28 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B4A0645E; Thu, 2 Sep 2021 12:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630580066; bh=lCdeDpUD1dQO0LCEAhNuQFiGzSwF87Eu3scwphNrJcw=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=S7x23e5QYy9HOPrHStEBkEhXNtTCf5jYOV49yggoqZawguZVuYF7pQWreOlFXYBu8 dS0iqnVY6d4YqG2V753PYnPtUvwcW4iW+YCrc5mRNuOOxctozl9rhd7uphkclSMIl/ hioOcw5y29lUqU1MyowewXqC5sGvJ14T7bapzQIM= Subject: Re: [PATCH] media: rcar_jpu: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Mikhail Ulyanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Renesas References: <20210901055532.7429-1-caihuoqing@baidu.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Thu, 2 Sep 2021 11:54:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901055532.7429-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc linux-renesas-soc On 01/09/2021 06:55, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar_jpu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c > index f57158bf2b11..56bb464629ed 100644 > --- a/drivers/media/platform/rcar_jpu.c > +++ b/drivers/media/platform/rcar_jpu.c > @@ -1590,7 +1590,6 @@ MODULE_DEVICE_TABLE(of, jpu_dt_ids); > static int jpu_probe(struct platform_device *pdev) > { > struct jpu *jpu; > - struct resource *res; > int ret; > unsigned int i; > > @@ -1603,8 +1602,7 @@ static int jpu_probe(struct platform_device *pdev) > jpu->dev = &pdev->dev; > > /* memory-mapped registers */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - jpu->regs = devm_ioremap_resource(&pdev->dev, res); > + jpu->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(jpu->regs)) > return PTR_ERR(jpu->regs); > >