linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: mpe@ellerman.id.au, mikey@neuling.org, apopple@linux.ibm.com,
	paulus@samba.org, npiggin@gmail.com,
	naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org,
	jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com,
	mingo@kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v3 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint
Date: Fri, 24 Apr 2020 09:02:12 +0530	[thread overview]
Message-ID: <f571127c-89b0-a333-be71-18f411dc6586@linux.ibm.com> (raw)
In-Reply-To: <67349339-03df-091a-47f0-78c1b14c5981@c-s.fr>

Hi Christophe,

>> @@ -101,14 +129,20 @@ static bool is_ptrace_bp(struct perf_event *bp)
>>    */
>>   void arch_unregister_hw_breakpoint(struct perf_event *bp)
>>   {
>> +    int i;
>> +
> 
> This declaration should be in the block using it.
> 
>>       /*
>>        * If the breakpoint is unregistered between a hw_breakpoint_handler()
>>        * and the single_step_dabr_instruction(), then cleanup the breakpoint
>>        * restoration variables to prevent dangling pointers.
>>        * FIXME, this should not be using bp->ctx at all! Sayeth peterz.
>>        */
>> -    if (bp->ctx && bp->ctx->task && bp->ctx->task != ((void *)-1L))
>> -        bp->ctx->task->thread.last_hit_ubp = NULL;
>> +    if (bp->ctx && bp->ctx->task && bp->ctx->task != ((void *)-1L)) {
> 
> Add declaration of 'int i' here.

How will that help? Keeping declaration at the start of function is also
common practice and I don't see any recommendation to move them inside
conditional block.

Thanks,
Ravi

  reply	other threads:[~2020-04-24  3:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  3:16 [PATCH v3 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 01/16] powerpc/watchpoint: Rename current DAWR macros Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 02/16] powerpc/watchpoint: Add SPRN macros for second DAWR Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 03/16] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 04/16] powerpc/watchpoint/ptrace: Return actual num of available watchpoints Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 05/16] powerpc/watchpoint: Provide DAWR number to set_dawr Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 07/16] powerpc/watchpoint: Get watchpoint count dynamically while disabling them Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 09/16] powerpc/watchpoint: Convert thread_struct->hw_brk to an array Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 10/16] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 11/16] powerpc/watchpoint: Introduce is_ptrace_bp() function Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros Ravi Bangoria
2020-04-14  5:48   ` Christophe Leroy
2020-04-24  3:24     ` Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint Ravi Bangoria
2020-04-14  5:53   ` Christophe Leroy
2020-04-24  3:32     ` Ravi Bangoria [this message]
2020-04-24  5:48       ` Christophe Leroy
2020-04-14  3:16 ` [PATCH v3 14/16] powerpc/watchpoint: Don't allow concurrent perf and ptrace events Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Ravi Bangoria
2020-04-14  3:16 ` [PATCH v3 16/16] powerpc/watchpoint/xmon: Support 2nd dawr Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f571127c-89b0-a333-be71-18f411dc6586@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=apopple@linux.ibm.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).