From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: ziy@nvidia.com, shy828301@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: migrate: Fix the return value of migrate_pages()
Date: Wed, 24 Nov 2021 10:46:44 -0800 [thread overview]
Message-ID: <f5964806-992c-d8e1-45f0-2181ee10a83f@oracle.com> (raw)
In-Reply-To: <76c241cc-5de7-d083-312c-373645ee8a77@linux.alibaba.com>
On 11/24/21 02:30, Baolin Wang wrote:
>
>
> On 2021/11/24 2:46, Mike Kravetz wrote:
>> On 11/7/21 01:57, Baolin Wang wrote:
>>> @@ -1511,18 +1517,20 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>>> case -ENOSYS:
>>> /* THP migration is unsupported */
>>> if (is_thp) {
>>> - if (!try_split_thp(page, &page2, from)) {
>>> + nr_thp_failed++;
>>> + if (!try_split_thp(page, &page2, &thp_split_pages)) {
>>
>> Does thp_split_pages need to be initialized before this call?
>
> The declaration "LIST_HEAD(thp_split_pages);" already did list initialization, right?
Correct. My bad! I keep forgetting,
#define LIST_HEAD(name) \
struct list_head name = LIST_HEAD_INIT(name)
--
Mike Kravetz
next prev parent reply other threads:[~2021-11-24 18:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 8:57 [PATCH 0/3] Improve the migration stats Baolin Wang
2021-11-07 8:57 ` [PATCH 1/3] mm: migrate: Fix the return value of migrate_pages() Baolin Wang
2021-11-09 18:10 ` Zi Yan
2021-11-23 18:46 ` Mike Kravetz
2021-11-24 10:30 ` Baolin Wang
2021-11-24 18:46 ` Mike Kravetz [this message]
2021-11-07 8:57 ` [PATCH 2/3] mm: migrate: Correct the hugetlb migration stats Baolin Wang
2021-11-16 4:21 ` Andrew Morton
2021-11-16 6:03 ` Baolin Wang
2021-11-23 19:25 ` Mike Kravetz
2021-11-24 10:47 ` Baolin Wang
2021-11-24 19:05 ` Mike Kravetz
2021-11-25 5:50 ` Baolin Wang
2021-11-07 8:57 ` [PATCH 3/3] mm: compaction: Fix the migration stats in trace_mm_compaction_migratepages() Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5964806-992c-d8e1-45f0-2181ee10a83f@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).