From: Quan Nguyen <quan@os.amperecomputing.com>
To: minyard@acm.org
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Wolfram Sang <wsa@kernel.org>,
openipmi-developer@lists.sourceforge.net,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v4 0/3] Add SSIF BMC driver
Date: Wed, 14 Jul 2021 07:20:13 +0700 [thread overview]
Message-ID: <f59af5c6-517c-0c93-ff7a-5a5edac4d5bf@os.amperecomputing.com> (raw)
In-Reply-To: <20210714001736.GD3406@minyard.net>
On 14/07/2021 07:17, Corey Minyard wrote:
> On Wed, Jul 14, 2021 at 06:29:27AM +0700, Quan Nguyen wrote:
>> On 13/07/2021 22:44, Corey Minyard wrote:
>>> On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
>>>> This series add support the SSIF BMC driver which is to perform in-band
>>>> IPMI communication with their host in management (BMC) side.
>>>
>>> Per the kernel build robot, looks like patch 3 introduces slave_enable()
>>> but patch 1 uses it.
>>>
>>> -corey
>>>
>> Thanks Corey,
>>
>> The order is not correct and kernel build robot found this hurts
>> bisectibility.
>> The patch 3 should be the first patch.
>
> Ok, can you re-submit in the right order?
>
> Thanks,
>
> -corey
>
Yes, I will re-submit new series with right order soon.
>>
>> - Quan
>>
>>>>
>>>> SSIF BMC driver in this series is tested with Aspeed AST2500.
>>>>
>>>> v4:
>>>> + Fix recursive spinlock [Graeme]
>>>> + Send response with Completion code 0xFF when aborting [Quan]
>>>> + Fix warning with dt_binding_check [Rob]
>>>> + Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]
>>>> + Added bounding check on SMBus writes and the whole request [Dan]
>>>> + Moved buffer to end of struct ssif_bmc_ctx to avoid context
>>>> corruption if somehow buffer is written past the end [Dan]
>>>> + Return -EINVAL if userspace buffer too small, dont
>>>> silence truncate [Corey, Joel]
>>>> + Not necessary to check NONBLOCK in lock [Corey]
>>>> + Enforce one user at a time [Joel]
>>>> + Reject write with invalid response length from userspace [Corey]
>>>> + Add state machines for better ssif bmc state handling [Quan]
>>>> + Drop ssif_bmc_aspeed.c and make ssif_bmc.c is generic
>>>> SSIF BMC driver [Quan]
>>>> + Change compatible string "aspeed,ast2500-ssif-bmc" to
>>>> "ampere,ssif-bmc" [Quan]
>>>> + Toggle Slave enable in i2c-aspeed to turn on/off slave mode [Ryan]
>>>> + Added slave_enable() to struct i2c_algorithm to control
>>>> slave mode and to address the recursive spinlock [Graeme, Ryan]
>>>> + Abort current request with invalid SMBus write or
>>>> invalid command [Quan]
>>>> + Abort all request if there is pending response [Quan]
>>>> + Changed validate_pec() to validate_request() [Quan]
>>>> + Add unsupported_smbus_cmd() to handle unknown SMBus command [Quan]
>>>> + Print internal state string for ease investigating issue [Quan]
>>>> + Move to READY state on SLAVE_STOP event [Quan]
>>>> + Change initilize_transfer() to process_smbus_cmd() [Quan]
>>>> + Introduce functions for each slave event [Quan]
>>>>
>>>> v3:
>>>> + Switched binding doc to use DT schema format [Rob]
>>>> + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel]
>>>> + Removed redundant license info [Joel]
>>>> + Switched to use traditional if-else [Joel]
>>>> + Removed unused ssif_bmc_ioctl() [Joel]
>>>> + Made handle_request()/complete_response() to return void [Joel]
>>>> + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request()
>>>> [Corey]
>>>> + Remove mutex [Corey]
>>>> + Use spin_lock/unlock_irqsave/restore in callback [Corey]
>>>> + Removed the unnecessary memset [Corey]
>>>> + Switch to use dev_err() [Corey]
>>>> + Combine mask/unmask two interrupts together [Corey]
>>>> + Fixed unhandled Tx done with NAK [Quan]
>>>> + Late ack'ed Tx done w/wo Ack irq [Quan]
>>>> + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy
>>>> to fix the deadlock [Graeme, Philipp, Quan]
>>>> + Clean buffer for last multipart read [Quan]
>>>> + Handle unknown incoming command [Quan]
>>>>
>>>> v2:
>>>> + Fixed compiling error with COMPILE_TEST for arc
>>>>
>>>> Quan Nguyen (3):
>>>> ipmi: ssif_bmc: Add SSIF BMC driver
>>>> bindings: ipmi: Add binding for SSIF BMC driver
>>>> i2c: aspeed: Add slave_enable() to toggle slave mode
>>>>
>>>> .../devicetree/bindings/ipmi/ssif-bmc.yaml | 38 +
>>>> drivers/char/ipmi/Kconfig | 11 +
>>>> drivers/char/ipmi/Makefile | 1 +
>>>> drivers/char/ipmi/ssif_bmc.c | 781 ++++++++++++++++++
>>>> drivers/char/ipmi/ssif_bmc.h | 106 +++
>>>> drivers/i2c/busses/i2c-aspeed.c | 20 +
>>>> include/linux/i2c.h | 2 +
>>>> 7 files changed, 959 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
>>>> create mode 100644 drivers/char/ipmi/ssif_bmc.c
>>>> create mode 100644 drivers/char/ipmi/ssif_bmc.h
>>>>
>>>> --
>>>> 2.28.0
>>>>
>>
prev parent reply other threads:[~2021-07-14 0:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 5:54 [PATCH v4 0/3] Add SSIF BMC driver Quan Nguyen
2021-07-13 5:54 ` [PATCH v4 1/3] ipmi: ssif_bmc: " Quan Nguyen
2021-07-13 5:54 ` [PATCH v4 2/3] bindings: ipmi: Add binding for " Quan Nguyen
2021-07-13 5:54 ` [PATCH v4 3/3] i2c: aspeed: Add slave_enable() to toggle slave mode Quan Nguyen
2021-07-13 15:44 ` [PATCH v4 0/3] Add SSIF BMC driver Corey Minyard
2021-07-13 23:29 ` Quan Nguyen
2021-07-14 0:17 ` Corey Minyard
2021-07-14 0:20 ` Quan Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59af5c6-517c-0c93-ff7a-5a5edac4d5bf@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).