From: Duncan Sands <duncan.sands@free.fr>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org
Cc: accessrunner-general@lists.sourceforge.net, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers: usb: atm: use pr_err() and pr_warn() instead of raw printk()
Date: Tue, 8 Dec 2020 10:41:52 +0100 [thread overview]
Message-ID: <f5c8d260-f617-4efe-c45e-b5846c24e3c0@free.fr> (raw)
In-Reply-To: <20201208093206.24780-3-info@metux.net>
On 12/8/20 10:32 AM, Enrico Weigelt, metux IT consult wrote:
> Since we have the nice helpers pr_err() and pr_warn(), use them instead
> of raw printk().
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Acked-by: Duncan Sands <duncan.sands@free.fr>
> ---
> drivers/usb/atm/usbatm.c | 2 +-
> drivers/usb/atm/xusbatm.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
> index 56fe30d247da..1c90aa273a41 100644
> --- a/drivers/usb/atm/usbatm.c
> +++ b/drivers/usb/atm/usbatm.c
> @@ -1278,7 +1278,7 @@ EXPORT_SYMBOL_GPL(usbatm_usb_disconnect);
> static int __init usbatm_usb_init(void)
> {
> if (sizeof(struct usbatm_control) > sizeof_field(struct sk_buff, cb)) {
> - printk(KERN_ERR "%s unusable with this kernel!\n", usbatm_driver_name);
> + pr_err("%s unusable with this kernel!\n", usbatm_driver_name);
> return -EIO;
> }
>
> diff --git a/drivers/usb/atm/xusbatm.c b/drivers/usb/atm/xusbatm.c
> index ffc9810070a3..0befbf63d1cc 100644
> --- a/drivers/usb/atm/xusbatm.c
> +++ b/drivers/usb/atm/xusbatm.c
> @@ -179,7 +179,7 @@ static int __init xusbatm_init(void)
> num_vendor != num_product ||
> num_vendor != num_rx_endpoint ||
> num_vendor != num_tx_endpoint) {
> - printk(KERN_WARNING "xusbatm: malformed module parameters\n");
> + pr_warn("xusbatm: malformed module parameters\n");
> return -EINVAL;
> }
>
>
prev parent reply other threads:[~2020-12-08 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 9:32 [PATCH 1/3] drivers: usb: atm: reduce noise Enrico Weigelt, metux IT consult
2020-12-08 9:32 ` [PATCH 2/3] drivers: usb: atm: use atm_info() instead of atm_printk(KERN_INFO Enrico Weigelt, metux IT consult
2020-12-08 9:32 ` [PATCH 3/3] drivers: usb: atm: use pr_err() and pr_warn() instead of raw printk() Enrico Weigelt, metux IT consult
2020-12-08 9:41 ` Duncan Sands [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c8d260-f617-4efe-c45e-b5846c24e3c0@free.fr \
--to=duncan.sands@free.fr \
--cc=accessrunner-general@lists.sourceforge.net \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).