From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2980FC4360C for ; Tue, 8 Oct 2019 06:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09AD12173B for ; Tue, 8 Oct 2019 06:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbfJHGjk (ORCPT ); Tue, 8 Oct 2019 02:39:40 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3217 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729937AbfJHGjj (ORCPT ); Tue, 8 Oct 2019 02:39:39 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 1BA09D3084733FCB0373; Tue, 8 Oct 2019 14:39:37 +0800 (CST) Received: from [127.0.0.1] (10.133.217.137) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Tue, 8 Oct 2019 14:39:33 +0800 Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code To: Petr Mladek , Linus Torvalds CC: Arnd Bergmann , Andy Whitcroft , "David S. Miller" , Sergey Senozhatsky , Peter Zijlstra , "Daniel Borkmann" , AlexeiStarovoitov , "Andrew Morton" , GregKroah-Hartman , Joe Perches , "Arnaldo Carvalho de Melo" , Ingo Molnar , References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> From: Kefeng Wang Message-ID: Date: Tue, 8 Oct 2019 14:39:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.217.137] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On 2019/10/2 16:55, Petr Mladek wrote: > Linus, > > On Fri 2019-09-20 14:25:12, Kefeng Wang wrote: >> There are pr_warning and pr_warng to show WARNING level message, >> most of the code using pr_warn, number based on next-20190919, >> >> pr_warn: 5189 pr_warning: 546 (tools: 398, others: 148) > > The ratio is 10:1 in favor of pr_warn(). It would make sense > to remove the pr_warning(). > > Would you accept pull request with these 32 simple patches > for rc2, please? > > Alternative is to run a simple sed. But it is not trivial > to fix indentation of the related lines. Kindly ping, should I respin patches with comments fixed? Is the patchset acceptable, hope to be clear that what to do next :) Thanks > > Best Regards, > Petr > > . >