From: David Laight <David.Laight@ACULAB.COM>
To: 'Masami Hiramatsu' <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Li Philip <philip.li@intel.com>,
Liu Yiding <yidingx.liu@intel.com>,
Xiao Yang <yangx.jy@cn.fujitsu.com>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: RE: [PATCH v2] selftests/ftrace: Use printf for backslash included command
Date: Mon, 11 May 2020 14:59:20 +0000 [thread overview]
Message-ID: <f61eda03333941958d62f9df93ba534b@AcuMS.aculab.com> (raw)
In-Reply-To: <20200511223804.9483cab03c9221818ff4fc5b@kernel.org>
> > + pos=$(printf "%s" "${2%^*}" | wc -c) # error position
> > + command=$(printf "%s" "$2" | tr -d ^)
You may want to put all the $(...) inside "" to avoid field splitting
(not relevant to a shell assignment with modern shells) and
filename globbing.
> > echo "Test command: $command"
> > echo > error_log
> > - (! echo "$command" >> "$3" ) 2> /dev/null
> > + (! printf "%s" "$command" >> "$3" ) 2> /dev/null
WTF is the (! for ??
The (...) is a subshell.
And ! inverts the exit status.
Neither is needed at all.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-05-11 14:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 13:37 [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Masami Hiramatsu
2020-05-01 13:37 ` [PATCH 1/3] selftests/ftrace: Make XFAIL green color Masami Hiramatsu
2020-05-01 14:15 ` Steven Rostedt
2020-05-01 13:37 ` [PATCH 2/3] selftests/ftrace: Pick only the first kprobe event to test Masami Hiramatsu
2020-05-01 14:17 ` Steven Rostedt
2020-05-01 15:38 ` shuah
2020-05-01 16:20 ` Steven Rostedt
2020-05-01 16:30 ` Shuah Khan
2020-05-02 3:05 ` Masami Hiramatsu
2020-05-01 13:38 ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Masami Hiramatsu
2020-05-01 14:19 ` Steven Rostedt
2020-05-02 3:08 ` Masami Hiramatsu
2020-05-07 13:12 ` Steven Rostedt
2020-05-07 15:50 ` Masami Hiramatsu
2020-05-07 17:25 ` Steven Rostedt
2020-05-07 20:32 ` Zanussi, Tom
2020-05-08 7:11 ` Masami Hiramatsu
2020-05-07 6:45 ` Xiao Yang
2020-05-07 9:15 ` Masami Hiramatsu
2020-05-11 7:22 ` Xiao Yang
2020-05-11 9:27 ` Masami Hiramatsu
2020-05-11 10:34 ` David Laight
2020-05-11 12:01 ` [PATCH] selftests/ftrace: Use /bin/echo for backslash included command Masami Hiramatsu
2020-05-11 12:19 ` Andreas Schwab
2020-05-11 13:36 ` [PATCH v2] selftests/ftrace: Use printf " Masami Hiramatsu
2020-05-11 13:38 ` Masami Hiramatsu
2020-05-11 13:46 ` David Laight
2020-05-11 14:05 ` Masami Hiramatsu
2020-05-11 14:59 ` David Laight [this message]
2020-05-11 20:28 ` Steven Rostedt
2020-05-11 13:42 ` Andreas Schwab
2020-05-11 13:58 ` Masami Hiramatsu
2020-05-25 9:59 ` Masami Hiramatsu
2020-05-28 16:24 ` Shuah Khan
2020-05-07 9:22 ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Andreas Schwab
2020-05-07 15:52 ` Masami Hiramatsu
2020-05-01 14:21 ` [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Steven Rostedt
2020-05-01 14:28 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61eda03333941958d62f9df93ba534b@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=philip.li@intel.com \
--cc=rostedt@goodmis.org \
--cc=schwab@linux-m68k.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
--cc=yangx.jy@cn.fujitsu.com \
--cc=yidingx.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).