From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924B7C3B1BF for ; Sun, 16 Feb 2020 22:34:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 395592084E for ; Sun, 16 Feb 2020 22:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=neuling.org header.i=@neuling.org header.b="izLMkKNK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727963AbgBPWdx (ORCPT ); Sun, 16 Feb 2020 17:33:53 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:57009 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbgBPWdx (ORCPT ); Sun, 16 Feb 2020 17:33:53 -0500 Received: from neuling.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 48LMNG3cXPz9sPk; Mon, 17 Feb 2020 09:33:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=neuling.org; s=201811; t=1581892431; bh=IzVd3zz9l6kPQTSe8Nj+Ga0PypI0I2VtiI7TPnVOQrY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=izLMkKNKro+4UaU4NyZyvFFwQxyAvV8WHby0/+sU16FohAkhCP8xpodCbETwQD4H+ Kbf5T+Sltm6K5SG7jU03OfXdEcvMoYnWbqk3qQtKTMEaEIjqlOvu/z7+ULva/ILRm0 A2nOGCJidPEC6Unmb1ho0W5lQMI5ZScWTAC4Ce/8n4M2gMdGfbvJuGK6WNknf1hkXg IcjRwX4qaH/u0dwUeDgY6sn+ejB/zd+Xce1n7lp4BnpsCaanSUe02Ewd/v2RTSnFIM VMSPrl7+RcB5nGZadKVKhkY9QebfoBRaxC0ynLtIjfyn1SKKbsfkcj8eo9AdIdNQAT nd1nCAkuHeJQA== Received: by neuling.org (Postfix, from userid 1000) id F1D392C01ED; Mon, 17 Feb 2020 09:33:49 +1100 (AEDT) Message-ID: Subject: Re: [PATCH 1/1] powerpc/cputable: Remove unnecessary copy of cpu_spec->oprofile_type From: Michael Neuling To: Leonardo Bras , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Greg Kroah-Hartman , Thomas Gleixner , desnesn@linux.ibm.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 17 Feb 2020 09:33:49 +1100 In-Reply-To: <20200215053637.280880-1-leonardo@linux.ibm.com> References: <20200215053637.280880-1-leonardo@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-02-15 at 02:36 -0300, Leonardo Bras wrote: > Before checking for cpu_type =3D=3D NULL, this same copy happens, so doin= g > it here will just write the same value to the t->oprofile_type > again. >=20 > Remove the repeated copy, as it is unnecessary. >=20 > Signed-off-by: Leonardo Bras LGTM Reviewed-by: Michael Neuling > --- > arch/powerpc/kernel/cputable.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputabl= e.c > index e745abc5457a..5a87ec96582f 100644 > --- a/arch/powerpc/kernel/cputable.c > +++ b/arch/powerpc/kernel/cputable.c > @@ -2197,7 +2197,6 @@ static struct cpu_spec * __init setup_cpu_spec(unsi= gned > long offset, > */ > if (old.oprofile_cpu_type !=3D NULL) { > t->oprofile_cpu_type =3D old.oprofile_cpu_type; > - t->oprofile_type =3D old.oprofile_type; > } > } > =20