From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andreas Böhler" <dev@aboehler.at>
Cc: Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: tps23861: add support for initializing the chip
Date: Thu, 25 Aug 2022 17:17:10 +0300 [thread overview]
Message-ID: <f64f493b-aad9-1811-3a9e-790f7613b99b@linaro.org> (raw)
In-Reply-To: <20220825141043.75354-1-dev@aboehler.at>
On 25/08/2022 17:10, Andreas Böhler wrote:
> The tps23861 driver does not initialize the chip and relies on it being
> in auto-mode by default. On some devices, these controllers default to
> OFF-Mode and hence cannot be used at all.
>
> This brings minimal support for initializing the controller in a user-
> defined mode.
>
> Tested on a TP-Link TL-SG2452P with 12x TI TPS23861 controllers.
>
> Signed-off-by: Andreas Böhler <dev@aboehler.at>
> ---
> .../bindings/hwmon/ti,tps23861.yaml | 76 +++++++++++++++++
Please run scripts/checkpatch.pl and fix the warnings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-25 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 14:10 [PATCH v2] hwmon: tps23861: add support for initializing the chip Andreas Böhler
2022-08-25 14:17 ` Krzysztof Kozlowski [this message]
2022-08-25 15:00 ` Guenter Roeck
2022-08-25 18:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f64f493b-aad9-1811-3a9e-790f7613b99b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=dev@aboehler.at \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).