From: Jason Wang <jasowang@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization <virtualization@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>,
netdev@vger.kernel.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 1/2] vdpa: support per virtqueue max queue size
Date: Wed, 7 Jul 2021 13:38:52 +0800 [thread overview]
Message-ID: <f655025b-5db4-a146-ff85-a211576e29af@redhat.com> (raw)
In-Reply-To: <CACycT3tMd750PQ0mgqCjHnxM4RmMcx2+Eo=2RBs2E2W3qPJang@mail.gmail.com>
在 2021/7/7 下午12:04, Yongji Xie 写道:
>> static long vhost_vdpa_get_vring_num(struct vhost_vdpa *v, u16 __user *argp)
>> {
>> - struct vdpa_device *vdpa = v->vdpa;
>> - const struct vdpa_config_ops *ops = vdpa->config;
>> u16 num;
>>
>> - num = ops->get_vq_num_max(vdpa);
>> + /*
>> + * VHOST_VDPA_GET_VRING_NUM asssumes a global max virtqueue
> s/asssumes/assumes. Other looks good to me.
>
> Thanks,
> Yongji
>
Will fix.
Thanks
prev parent reply other threads:[~2021-07-07 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 7:19 [PATCH 1/2] vdpa: support per virtqueue max queue size Jason Wang
2021-07-05 7:19 ` [PATCH 2/2] vdpa: vp_vdpa: don't use hard-coded maximum virtqueue size Jason Wang
2021-07-05 7:26 ` Michael S. Tsirkin
2021-07-05 7:29 ` Jason Wang
2021-07-05 17:59 ` Michael S. Tsirkin
2021-07-06 2:30 ` Jason Wang
2021-07-06 13:14 ` [PATCH 1/2] vdpa: support per virtqueue max queue size Stefan Hajnoczi
2021-07-07 4:04 ` Yongji Xie
2021-07-07 5:38 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f655025b-5db4-a146-ff85-a211576e29af@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).