From: Andrew Lunn <andrew@lunn.ch>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com, Sergey Shtylyov <s.shtylyov@omp.ru>,
Steve Glendinning <steve.glendinning@shawell.net>,
Wells Lu <wellslutw@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Date: Tue, 21 Mar 2023 21:17:28 +0100 [thread overview]
Message-ID: <f657b9c5-961d-4b2f-a7e2-47a2a66de9dd@lunn.ch> (raw)
In-Reply-To: <20230321131745.27688-1-wsa+renesas@sang-engineering.com>
On Tue, Mar 21, 2023 at 02:17:45PM +0100, Wolfram Sang wrote:
> phy_disconnect() calls phy_detach() which already clears 'phydev' if it
> is attached to a struct net_device.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-03-21 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:17 [PATCH net-next] ethernet: remove superfluous clearing of phydev Wolfram Sang
2023-03-21 20:17 ` Andrew Lunn [this message]
2023-03-21 20:38 ` Florian Fainelli
2023-03-23 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f657b9c5-961d-4b2f-a7e2-47a2a66de9dd@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=steve.glendinning@shawell.net \
--cc=wellslutw@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).