From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
mingo@redhat.com, lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH] xen: setup pv irq ops vector earlier
Date: Mon, 2 Jul 2018 13:27:55 +0200 [thread overview]
Message-ID: <f6615f1c-6835-eba5-7b38-be06927700c9@suse.com> (raw)
In-Reply-To: <5B3A09EA02000078001CFBB7@suse.com>
On 02/07/18 13:18, Jan Beulich wrote:
>>>> On 02.07.18 at 12:00, <jgross@suse.com> wrote:
>> --- a/arch/x86/xen/enlighten_pv.c
>> +++ b/arch/x86/xen/enlighten_pv.c
>> @@ -1213,6 +1213,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
>> pv_info = xen_info;
>> pv_init_ops.patch = paravirt_patch_default;
>> pv_cpu_ops = xen_cpu_ops;
>> + xen_init_irq_ops();
>
> Isn't this still too late? xen_setup_machphys_mapping(), for example,
> has a WARN_ON(), which implies multiple printk()s.
Seems as if it would be a good idea to move calling
xen_setup_machphys_mapping() into xen_init_mmu_ops(). There is really
no need to do it earlier.
Juergen
next prev parent reply other threads:[~2018-07-02 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 10:00 [PATCH] xen: setup pv irq ops vector earlier Juergen Gross
2018-07-02 11:18 ` [Xen-devel] " Jan Beulich
[not found] ` <5B3A09EA02000078001CFBB7@suse.com>
2018-07-02 11:27 ` Juergen Gross [this message]
2018-07-10 22:26 ` Boris Ostrovsky
2018-07-11 5:08 ` Juergen Gross
2018-07-11 15:31 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6615f1c-6835-eba5-7b38-be06927700c9@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).