From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Aran Dalton <arda@allwinnertech.com>, <johannes@sipsolutions.net>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Cc: <johannes.berg@intel.com>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cfg80211: fix dead lock for nl80211_new_interface()
Date: Wed, 21 Sep 2022 08:03:04 -0700 [thread overview]
Message-ID: <f663ce29-72e7-7592-d4ef-d79fda1de102@quicinc.com> (raw)
In-Reply-To: <20220921091913.110749-1-arda@allwinnertech.com>
On 9/21/2022 2:19 AM, Aran Dalton wrote:
> Both nl80211_new_interface and cfg80211_netdev_notifier_call hold the
> same wiphy_lock, then cause deadlock.
>
> The main call stack as bellow:
>
> nl80211_new_interface() takes wiphy_lock
> -> _nl80211_new_interface:
> -> rdev_add_virtual_intf
> -> rdev->ops->add_virtual_intf
> -> register_netdevice
> -> call_netdevice_notifiers(NETDEV_REGISTER, dev);
> -> call_netdevice_notifiers_extack
> -> call_netdevice_notifiers_info
> -> raw_notifier_call_chain
> -> cfg80211_netdev_notifier_call
> -> wiphy_lock(&rdev->wiphy), cfg80211_register_wdev
In both of your patches please describe what you are doing in the patch
to fix the problem, and in particular describe why your fix is safe.
>
> Fixes: ea6b2098dd02 ("cfg80211: fix locking in netlink owner interface destruction")
> Signed-off-by: Aran Dalton <arda@allwinnertech.com>
> ---
> net/wireless/nl80211.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 2705e3ee8fc4..bdacddc3ffa3 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -4260,9 +4260,7 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info)
> /* to avoid failing a new interface creation due to pending removal */
> cfg80211_destroy_ifaces(rdev);
>
> - wiphy_lock(&rdev->wiphy);
> ret = _nl80211_new_interface(skb, info);
> - wiphy_unlock(&rdev->wiphy);
>
> return ret;
> }
next prev parent reply other threads:[~2022-09-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:19 [PATCH 1/2] cfg80211: fix dead lock for nl80211_new_interface() Aran Dalton
2022-09-21 9:19 ` [PATCH 2/2] cfg80211: fix dead lock for nl80211_del_interface() Aran Dalton
2022-09-21 15:03 ` Jeff Johnson [this message]
2022-09-21 16:36 ` [PATCH 1/2] cfg80211: fix dead lock for nl80211_new_interface() Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f663ce29-72e7-7592-d4ef-d79fda1de102@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=arda@allwinnertech.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).