From: "Horia Geantă" <horia.geanta@nxp.com>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Gaurav Jain <gaurav.jain@nxp.com>, Varun Sethi <V.Sethi@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 1/1] crypto: caam/rng: Add support for PRNG
Date: Wed, 27 Apr 2022 14:48:39 +0300 [thread overview]
Message-ID: <f67acb13-a48e-763b-dce6-d3867b0e4965@nxp.com> (raw)
In-Reply-To: <20220420063808.1089283-2-meenakshi.aggarwal@nxp.com>
On 4/20/2022 9:38 AM, Meenakshi Aggarwal wrote:
> +static void caam_prng_done(struct device *jrdev, u32 *desc, u32 err,
> + void *context)
> +{
> + struct caam_prng_ctx *jctx = context;
> +
> + if (err >> JRSTA_SSRC_SHIFT)
> + jctx->err = caam_jr_strstatus(jrdev, err);
The details of error handling are in error.c, let's keep this abstraction.
> + else
> + jctx->err = 0;
> +
> + complete(&jctx->done);
> +}
> +
[...]
> +static int caam_prng_seed(struct crypto_rng *tfm,
> + const u8 *seed, unsigned int slen)
> +{
> + struct caam_prng_ctx ctx;
> + struct device *jrdev;
> + dma_addr_t seed_dma;
> + u32 *desc;
> + u8 *buf;
> + int ret = 0;
> +
> + if (seed == NULL) {
> + pr_err("Seed not provided\n");
> + return ret;
> + }
> +
> + buf = kzalloc(slen, GFP_KERNEL);
> + if (!buf)
> + return -ENOMEM;
> +
> + jrdev = caam_jr_alloc();
> + ret = PTR_ERR_OR_ZERO(jrdev);
> + if (ret) {
> + pr_err("Job Ring Device allocation failed\n");
> + kfree(buf);
> + return ret;
> + }
> +
> + desc = kzalloc(CAAM_PRNG_DESC_LEN, GFP_KERNEL | GFP_DMA);
> + if (!desc) {
> + ret = -ENOMEM;
> + goto out1;
> + }
> +
> + memcpy(buf, seed, slen);
> +
> + seed_dma = dma_map_single(jrdev, buf, slen, DMA_FROM_DEVICE);
Now that seedsize is 0, the .seed callback is called with slen = 0.
Reseed descriptor should be updated too.
Horia
next prev parent reply other threads:[~2022-04-27 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:41 [PATCH] crypto: caam/rng: Add support for PRNG meenakshi.aggarwal
2022-03-08 22:49 ` kernel test robot
2022-03-16 18:01 ` [PATCH v2 0/1] " meenakshi.aggarwal
2022-03-16 18:01 ` [PATCH v2 1/1] " meenakshi.aggarwal
2022-04-05 12:31 ` Horia Geantă
2022-04-20 5:57 ` Meenakshi Aggarwal
2022-04-20 6:38 ` [PATCH v3 0/1] " meenakshi.aggarwal
2022-04-20 6:38 ` [PATCH v3 1/1] " meenakshi.aggarwal
2022-04-27 11:48 ` Horia Geantă [this message]
2022-04-29 8:45 ` [PATCH v4 0/1] " meenakshi.aggarwal
2022-04-29 8:45 ` [PATCH v4 1/1] " meenakshi.aggarwal
2022-04-29 11:01 ` Horia Geantă
2022-04-29 11:48 ` [PATCH v5 0/1] " meenakshi.aggarwal
2022-04-29 11:48 ` [PATCH v5 1/1] " meenakshi.aggarwal
2022-05-06 10:22 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67acb13-a48e-763b-dce6-d3867b0e4965@nxp.com \
--to=horia.geanta@nxp.com \
--cc=V.Sethi@nxp.com \
--cc=davem@davemloft.net \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshi.aggarwal@nxp.com \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).