From: ayaka <ayaka@soulik.info>
To: Caesar Wang <wxt@rock-chips.com>,
edubezval@gmail.com, rui.zhang@intel.com
Cc: linux-pm@vger.kernel.org, briannorris@chromium.org,
linux-kernel@vger.kernel.org, smbarber@chromium.org,
linux-rockchip@lists.infradead.org,
"randy.li@rock-chips.com" <randy.li@rock-chips.com>
Subject: Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal
Date: Sat, 31 Dec 2016 00:11:25 +0800 [thread overview]
Message-ID: <f68125d7-01bb-d0d9-d04f-8d1b5cff19a2@soulik.info> (raw)
In-Reply-To: <1481540735-12710-1-git-send-email-wxt@rock-chips.com>
BTW, Caesar have you ever met this at RK3288 at booting time?
[ 8.430582] thermal thermal_zone1: critical temperature reached(125
C),shutting down
[ 8.439038] thermal thermal_zone2: critical temperature reached(125
C),shutting down
[ 8.456344] thermal thermal_zone1: critical temperature reached(125
C),shutting down
[ 8.465298] thermal thermal_zone2: critical temperature reached(125
C),shutting down
On 12/12/2016 07:05 PM, Caesar Wang wrote:
> There are five patches posted for upstream.
> 89267b5 thermal: rockchip: improve conversion error messages
> a0b5649 thermal: rockchip: don't pass table structs by value
> bceed92 thermal: rockchip: fixes invalid temperature case
> 30be6d0 thermal: rockchip: optimize the conversion table
> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
> --
>
> History version:
> V1:
> https://lkml.org/lkml/2016/11/22/250
> V2:
> https://lkml.org/lkml/2016/11/23/348
> V3:
> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1281432.html
> ---
>
> Brain posted the below patches for upstream.
> 89267b5 thermal: rockchip: improve conversion error messages
> a0b5649 thermal: rockchip: don't pass table structs by value
> That make sense to improve efficiency
>
> Caesar post the below patches for upstream.
> bceed92 thermal: rockchip: fixes invalid temperature case
> 30be6d0 thermal: rockchip: optimize the conversion table
> 35636e9 thermal: rockchip: handle the set_trips without the trip points.
> That will fixes some issues in special cases.
> --
>
> Anyway, this series patches should can improve the rockchip thermal driver.
>
>
> Changes in v4:
> - As Eduardo and Brian commnets on
> https://patchwork.kernel.org/patch/9449301
> - Print a better name.
> - As Eduardo commented on https://patchwork.kernel.org/patch/9449313/
> - remove the Brain's review for previous version, since the new version
> update something.
>
> Changes in v3:
> - fix trivial thing for error message nd return value.
> - change the commit.
> - Fixes something as Brian comments on
>
> Changes in v2:
> - As Brian commnets that restructure this to pass error codes back to the
> upper layers.
> - Improve the commit message.
> - improve the commit as Brian commnets on https://patchwork.kernel.org/patch/9440985
> - Fixes something as Brian comments on
> https://patchwork.kernel.org/patch/9440989.
>
> Changes in v1:
> - The original Brian posted on https://patchwork.kernel.org/patch/9437686
> Note: it'd probably be even nicer to know which sensor this was, but we've
> kinda abstracted that one away by this point...
> - The original Brian posted on https://patchwork.kernel.org/patch/9437687
>
> Brian Norris (2):
> thermal: rockchip: improve conversion error messages
> thermal: rockchip: don't pass table structs by value
>
> Caesar Wang (3):
> thermal: rockchip: fixes invalid temperature case
> thermal: rockchip: optimize the conversion table
> thermal: rockchip: handle set_trips without the trip points
>
> drivers/thermal/rockchip_thermal.c | 153 ++++++++++++++++++++++++-------------
> 1 file changed, 100 insertions(+), 53 deletions(-)
>
next prev parent reply other threads:[~2016-12-30 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 11:05 [PATCH v4 0/5] thermal: fixes the rockchip thermal Caesar Wang
2016-12-12 11:05 ` [PATCH v4 1/5] thermal: rockchip: improve conversion error messages Caesar Wang
2016-12-12 11:05 ` [PATCH v4 2/5] thermal: rockchip: don't pass table structs by value Caesar Wang
2016-12-12 11:05 ` [PATCH v4 3/5] thermal: rockchip: fixes invalid temperature case Caesar Wang
2016-12-12 11:05 ` [PATCH v4 4/5] thermal: rockchip: optimize the conversion table Caesar Wang
2016-12-12 11:05 ` [PATCH v4 5/5] thermal: rockchip: handle set_trips without the trip points Caesar Wang
2016-12-30 16:11 ` ayaka [this message]
2017-01-02 13:16 ` [PATCH v4 0/5] thermal: fixes the rockchip thermal Caesar Wang
2017-01-02 23:57 ` Randy Li
2017-01-03 1:02 ` Caesar Wang
2017-01-03 1:13 ` Randy Li
2017-01-03 16:30 ` ayaka
2017-01-14 16:54 ` Eduardo Valentin
2017-01-15 3:35 ` ayaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f68125d7-01bb-d0d9-d04f-8d1b5cff19a2@soulik.info \
--to=ayaka@soulik.info \
--cc=briannorris@chromium.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=randy.li@rock-chips.com \
--cc=rui.zhang@intel.com \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).