From: Iouri Tarassov <iourit@linux.microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Pavel Machek <pavel@denx.de>, Sasha Levin <sashal@kernel.org>,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, iourit@microsoft.com,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
spronovo@microsoft.com
Subject: Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code
Date: Thu, 3 Sep 2020 14:39:05 -0700 [thread overview]
Message-ID: <f68415b4-f76d-680a-cc4f-2647fe54e538@linux.microsoft.com> (raw)
In-Reply-To: <20200828061840.GE56396@kroah.com>
Hi Greg,
On 8/27/2020 11:18 PM, Greg KH wrote:
> On Thu, Aug 27, 2020 at 05:25:23PM -0700, Iouri Tarassov wrote:
> > > > +bool dxghwqueue_acquire_reference(struct dxghwqueue *hwqueue)
> > > > +{
> > > > + return refcount_inc_not_zero(&hwqueue->refcount);
> > > > +}
> > >
> > > Midlayers are evil.
> > I strongly agree in general, but think that in our case the layers are very
> > small. It allows to quickly find all places where a reference/dereference on
> > an object is done and addition of debug tracing to catch errors.
>
> Again, no, please remove all layers like this. They just make it
> impossible for others to review and understand the code over time.
>
> Also, in this specific case, it would have allowed me to easily realize
> that you are doing this type of call incorrectly and should be using a
> different data structure :)
Are you suggesting that the current code is incorrect? Could you comment
what changes need to be done?
Thanks
Iouri
next prev parent reply other threads:[~2020-09-03 21:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 12:38 [PATCH 0/4] drivers: hv: Microsoft Virtual GPU Driver Sasha Levin
2020-08-14 12:38 ` [PATCH 1/4] drivers: hv: dxgkrnl: core code Sasha Levin
2020-08-14 12:55 ` Greg KH
2020-08-27 23:29 ` Iouri Tarassov
2020-08-28 6:01 ` Greg KH
2020-08-14 12:57 ` Greg KH
2020-08-27 23:45 ` Iouri Tarassov
2020-08-28 6:15 ` Greg KH
2020-08-14 13:04 ` Greg KH
2020-08-28 0:05 ` Iouri Tarassov
2020-08-28 6:12 ` Greg KH
2020-09-03 18:55 ` Iouri Tarassov
2020-09-03 19:32 ` Greg KH
2020-08-14 13:18 ` Wei Liu
2020-08-26 20:20 ` Iouri Tarassov
2020-08-27 0:12 ` Iouri Tarassov
2020-08-27 19:09 ` Iouri Tarassov
2020-08-21 13:53 ` Pavel Machek
2020-08-28 0:25 ` Iouri Tarassov
2020-08-28 6:17 ` Greg KH
2020-08-28 6:18 ` Greg KH
2020-09-03 21:39 ` Iouri Tarassov [this message]
2020-09-04 5:18 ` Greg KH
2020-08-14 12:38 ` [PATCH 2/4] drivers: hv: dxgkrnl: hook up dxgkrnl Sasha Levin
2020-08-14 12:38 ` [PATCH 3/4] drivers: hv: vmbus: " Sasha Levin
2020-08-14 12:38 ` [PATCH 4/4] drivers: hv: dxgkrnl: create a MAINTAINERS entry Sasha Levin
2020-08-14 13:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f68415b4-f76d-680a-cc4f-2647fe54e538@linux.microsoft.com \
--to=iourit@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=iourit@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=sashal@kernel.org \
--cc=spronovo@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).