From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <bjorn.andersson@linaro.org>, <ohad@wizery.com>,
<loic.pallardy@st.com>, <s-anna@ti.com>,
<linux-remoteproc@vger.kernel.org>, <corbet@lwn.net>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 12/14] remoteproc: Introducing function rproc_set_state_machine()
Date: Mon, 4 May 2020 14:00:45 +0200 [thread overview]
Message-ID: <f686ac42-844b-d1c0-913a-c23f42834133@st.com> (raw)
In-Reply-To: <20200430205143.GC18004@xps15>
On 4/30/20 10:51 PM, Mathieu Poirier wrote:
> On Wed, Apr 29, 2020 at 04:38:54PM +0200, Arnaud POULIQUEN wrote:
>>
>>
>> On 4/29/20 11:22 AM, Arnaud POULIQUEN wrote:
>>>
>>>
>>> On 4/24/20 10:01 PM, Mathieu Poirier wrote:
>>>> Introducting function rproc_set_state_machine() to add
>>>> operations and a set of flags to use when synchronising with
>>>> a remote processor.
>>>>
>>>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>>>> ---
>>>> drivers/remoteproc/remoteproc_core.c | 54 ++++++++++++++++++++++++
>>>> drivers/remoteproc/remoteproc_internal.h | 6 +++
>>>> include/linux/remoteproc.h | 3 ++
>>>> 3 files changed, 63 insertions(+)
>>>>
>>>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>>>> index 48afa1f80a8f..5c48714e8702 100644
>>>> --- a/drivers/remoteproc/remoteproc_core.c
>>>> +++ b/drivers/remoteproc/remoteproc_core.c
>>>> @@ -2065,6 +2065,59 @@ int devm_rproc_add(struct device *dev, struct rproc *rproc)
>>>> }
>>>> EXPORT_SYMBOL(devm_rproc_add);
>>>>
>>>> +/**
>>>> + * rproc_set_state_machine() - Set a synchronisation ops and set of flags
>>>> + * to use with a remote processor
>>>> + * @rproc: The remote processor to work with
>>>> + * @sync_ops: The operations to use when synchronising with a remote
>>>> + * processor
>>>> + * @sync_flags: The flags to use when deciding if the remoteproc core
>>>> + * should be synchronising with a remote processor
>>>> + *
>>>> + * Returns 0 on success, an error code otherwise.
>>>> + */
>>>> +int rproc_set_state_machine(struct rproc *rproc,
>>>> + const struct rproc_ops *sync_ops,
>>>> + struct rproc_sync_flags sync_flags)
>>>
>>> So this API should be called by platform driver only in case of synchronization
>>> support, right?
>>> In this case i would rename it as there is also a state machine in "normal" boot
>>> proposal: rproc_set_sync_machine or rproc_set_sync_state_machine
>>>
>>
>> Reviewing the stm32 series, i wonder if sync_flags should be a pointer to a const structure
>> as the platform driver should not update it during the rproc live cycle.
>> Then IMO, using a pointer to the structure instead of the structure seems more
>> in line with the rest of the remoteproc API.
>
> Humm... If we do make sync_flags constant then the platform drivers can't modify
> the values dynamically, as I did in the stm32 series. This is something Loic
> had asked for.
>
> Moreover function rproc_set_state_machine() can't be called twice so updating
> the sync_flags can't happen.
You are right, make it constant is not a good idea.
Regards,
Arnaud
>
>>
>>>> +{
>>>> + if (!rproc || !sync_ops)
>>>> + return -EINVAL;
>>>> +
>>>> + /*
>>>> + * No point in going further if we never have to synchronise with
>>>> + * the remote processor.
>>>> + */
>>>> + if (!sync_flags.on_init &&
>>>> + !sync_flags.after_stop && !sync_flags.after_crash)
>>>> + return 0;
>>>> +
>>>> + /*
>>>> + * Refuse to go further if remoteproc operations have been allocated
>>>> + * but they will never be used.
>>>> + */
>>>> + if (rproc->ops && sync_flags.on_init &&
>>>> + sync_flags.after_stop && sync_flags.after_crash)
>>>> + return -EINVAL;
>>>> +
>>>> + /*
>>>> + * Don't allow users to set this more than once to avoid situations
>>>> + * where the remote processor can't be recovered.
>>>> + */
>>>> + if (rproc->sync_ops)
>>>> + return -EINVAL;
>>>> +
>>>> + rproc->sync_ops = kmemdup(sync_ops, sizeof(*sync_ops), GFP_KERNEL);
>>>> + if (!rproc->sync_ops)
>>>> + return -ENOMEM;
>>>> +
>>>> + rproc->sync_flags = sync_flags;
>>>> + /* Tell the core what to do when initialising */
>>>> + rproc_set_sync_flag(rproc, RPROC_SYNC_STATE_INIT);
>>>
>>> Is there a use case where sync_flags.on_init is false and other flags are true?
>>>
>>> Look like on_init is useless and should not be exposed to the platform driver.
>>> Or comments are missing to explain the usage of it vs the other flags.
>>>
>>> Regards,
>>> Arnaud
>>>
>>>> +
>>>> + return 0;
>>>> +}
>>>> +EXPORT_SYMBOL(rproc_set_state_machine);
>>>> +
>>>> /**
>>>> * rproc_type_release() - release a remote processor instance
>>>> * @dev: the rproc's device
>>>> @@ -2088,6 +2141,7 @@ static void rproc_type_release(struct device *dev)
>>>> kfree_const(rproc->firmware);
>>>> kfree_const(rproc->name);
>>>> kfree(rproc->ops);
>>>> + kfree(rproc->sync_ops);
>>>> kfree(rproc);
>>>> }
>>>>
>>>> diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
>>>> index 7dcc0a26892b..c1a293a37c78 100644
>>>> --- a/drivers/remoteproc/remoteproc_internal.h
>>>> +++ b/drivers/remoteproc/remoteproc_internal.h
>>>> @@ -27,6 +27,8 @@ struct rproc_debug_trace {
>>>> /*
>>>> * enum rproc_sync_states - remote processsor sync states
>>>> *
>>>> + * @RPROC_SYNC_STATE_INIT state to use when the remoteproc core
>>>> + * is initialising.
>>>> * @RPROC_SYNC_STATE_SHUTDOWN state to use after the remoteproc core
>>>> * has shutdown (rproc_shutdown()) the
>>>> * remote processor.
>>>> @@ -39,6 +41,7 @@ struct rproc_debug_trace {
>>>> * operation to use.
>>>> */
>>>> enum rproc_sync_states {
>>>> + RPROC_SYNC_STATE_INIT,
>>>> RPROC_SYNC_STATE_SHUTDOWN,
>>>> RPROC_SYNC_STATE_CRASHED,
>>>> };
>>>> @@ -47,6 +50,9 @@ static inline void rproc_set_sync_flag(struct rproc *rproc,
>>>> enum rproc_sync_states state)
>>>> {
>>>> switch (state) {
>>>> + case RPROC_SYNC_STATE_INIT:
>>>> + rproc->sync_with_rproc = rproc->sync_flags.on_init;
>>>> + break;
>>>> case RPROC_SYNC_STATE_SHUTDOWN:
>>>> rproc->sync_with_rproc = rproc->sync_flags.after_stop;
>>>> break;
>>>> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
>>>> index ceb3b2bba824..a75ed92b3de6 100644
>>>> --- a/include/linux/remoteproc.h
>>>> +++ b/include/linux/remoteproc.h
>>>> @@ -619,6 +619,9 @@ struct rproc *rproc_get_by_child(struct device *dev);
>>>> struct rproc *rproc_alloc(struct device *dev, const char *name,
>>>> const struct rproc_ops *ops,
>>>> const char *firmware, int len);
>>>> +int rproc_set_state_machine(struct rproc *rproc,
>>>> + const struct rproc_ops *sync_ops,
>>>> + struct rproc_sync_flags sync_flags);
>>>> void rproc_put(struct rproc *rproc);
>>>> int rproc_add(struct rproc *rproc);
>>>> int rproc_del(struct rproc *rproc);
>>>>
next prev parent reply other threads:[~2020-05-04 12:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:01 [PATCH v3 00/14] remoteproc: Add support for synchronisaton with rproc Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 01/14] remoteproc: Make core operations optional Mathieu Poirier
2020-04-28 16:18 ` Arnaud POULIQUEN
2020-04-30 19:39 ` Mathieu Poirier
2020-05-05 22:16 ` Bjorn Andersson
2020-05-08 19:09 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 02/14] remoteproc: Introduce function rproc_alloc_internals() Mathieu Poirier
2020-05-05 22:31 ` Bjorn Andersson
2020-05-08 19:37 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 03/14] remoteproc: Add new operation and flags for synchronistation Mathieu Poirier
2020-04-28 16:38 ` Arnaud POULIQUEN
2020-04-30 19:49 ` Mathieu Poirier
2020-05-06 0:22 ` Bjorn Andersson
2020-05-08 21:01 ` Mathieu Poirier
2020-05-14 1:32 ` Bjorn Andersson
2020-05-15 19:24 ` Mathieu Poirier
2020-05-19 0:55 ` Bjorn Andersson
2020-05-20 22:06 ` Mathieu Poirier
2020-05-21 5:21 ` Bjorn Andersson
2020-05-21 21:55 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 04/14] remoteproc: Refactor function rproc_boot() Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 05/14] remoteproc: Refactor function rproc_fw_boot() Mathieu Poirier
2020-05-06 0:33 ` Bjorn Andersson
2020-05-08 21:27 ` Mathieu Poirier
2020-05-14 2:10 ` Bjorn Andersson
2020-05-15 19:46 ` Mathieu Poirier
2020-05-19 0:22 ` Bjorn Andersson
2020-04-24 20:01 ` [PATCH v3 06/14] remoteproc: Refactor function rproc_trigger_auto_boot() Mathieu Poirier
2020-04-28 17:00 ` Arnaud POULIQUEN
2020-04-24 20:01 ` [PATCH v3 07/14] remoteproc: Introducting new start and stop functions Mathieu Poirier
2020-05-06 0:42 ` Bjorn Andersson
2020-04-24 20:01 ` [PATCH v3 08/14] remoteproc: Call core functions based on synchronisation flag Mathieu Poirier
2020-04-28 17:27 ` Arnaud POULIQUEN
2020-04-30 19:57 ` Mathieu Poirier
2020-05-04 11:14 ` Arnaud POULIQUEN
2020-05-05 22:10 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 09/14] remoteproc: Deal with synchronisation when crashing Mathieu Poirier
2020-04-29 7:44 ` Arnaud POULIQUEN
2020-04-30 20:11 ` Mathieu Poirier
2020-05-06 1:01 ` Bjorn Andersson
2020-05-08 21:47 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 10/14] remoteproc: Deal with synchronisation when shutting down Mathieu Poirier
2020-04-29 8:19 ` Arnaud POULIQUEN
2020-04-30 20:23 ` Mathieu Poirier
2020-05-04 11:34 ` Arnaud POULIQUEN
2020-05-05 22:03 ` Mathieu Poirier
2020-05-06 7:51 ` Arnaud POULIQUEN
2020-05-06 1:10 ` Bjorn Andersson
2020-04-24 20:01 ` [PATCH v3 11/14] remoteproc: Deal with synchronisation when changing FW image Mathieu Poirier
2020-04-29 8:52 ` Arnaud POULIQUEN
2020-04-30 20:32 ` Mathieu Poirier
2020-05-06 1:27 ` Bjorn Andersson
2020-04-24 20:01 ` [PATCH v3 12/14] remoteproc: Introducing function rproc_set_state_machine() Mathieu Poirier
2020-04-29 9:22 ` Arnaud POULIQUEN
2020-04-29 14:38 ` Arnaud POULIQUEN
2020-04-30 20:51 ` Mathieu Poirier
2020-05-04 12:00 ` Arnaud POULIQUEN [this message]
2020-04-30 20:42 ` Mathieu Poirier
2020-05-04 11:57 ` Arnaud POULIQUEN
2020-05-05 21:43 ` Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 13/14] remoteproc: Document " Mathieu Poirier
2020-04-24 20:01 ` [PATCH v3 14/14] remoteproc: Expose synchronisation flags via debugfs Mathieu Poirier
2020-05-18 13:28 ` [PATCH v3 00/14] remoteproc: Add support for synchronisaton with rproc Peng Fan
2020-05-18 16:29 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f686ac42-844b-d1c0-913a-c23f42834133@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).