From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbeABXzr (ORCPT + 1 other); Tue, 2 Jan 2018 18:55:47 -0500 Received: from mail-co1nam03on0072.outbound.protection.outlook.com ([104.47.40.72]:33376 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750937AbeABXzo (ORCPT ); Tue, 2 Jan 2018 18:55:44 -0500 Subject: Re: [PATCH v3 0/3] Support Perf Extension on AMD KVM guests To: kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Paolo Bonzini , Radim Krcmar , Len Brown , Kyle Huey , Tom Lendacky , Borislav Petkov , Grzegorz Andrejczuk , Kan Liang References: From: "Natarajan, Janakarajan" Message-ID: Date: Tue, 2 Jan 2018 17:55:32 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR2201CA0087.namprd22.prod.outlook.com (10.174.103.40) To BN6PR12MB1667.namprd12.prod.outlook.com (10.172.19.18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f63ece4-9fcf-435d-4fb7-08d5523c53c7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060);SRVR:BN6PR12MB1667; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;3:8Fh+o9bW9yPA88TvuJHkuM9r7uyRUAnRBrXM6CNsZLvmrPFNvXf2k3peIQo+ffMBBMnYUXw13WzCgsNnVoXXWkJ1pnN3sU0xQxvfaBuV9FtnHS7D7YX1jV9uLagaGZFFv7JWYxuTqBUAYLa7WUbXazZ4jrlSKtXBxiQR7dW1kadIGzny5TQjTkNmArZPu1Z1YTe1r79clR5JrzlxFpB4dUw6NaibDlie6c49le6rkI6dPPRg7HEsLz+c1T3DLCq5;25:mq8MLUVfp6k5VuqE48031GGIuV0zE/XFH/Tf8cP5veXHetuiAMVv6g+TAkjGmIYO2JCR7aCnLIVDNbN4KWJvlqs3AFjyAymZM7yN4uAUJRRoR0MAiF0N/hl54lJjFMhOfdXKQetssGjB6ZFuKbEXg4rQ7f8ocRTBtdvT0EB9HLXKHkSAfgSDtLMQXKQJvyofzPrP5hEc+0t9jD389Gq64AQx4J6wK4EqunH2BtjOcM985cHIh3rD8d1ZP6MT++EWz15Ou86GwncvN3I6Smpevqk4l5yMHnSCAFZThRK2M6MEda22ggvIUyvTwNzcNPNyB0KL4efEah9hdGVe8/iMeg==;31:dT0ZprBfhqdxR+DDS9q9Z+wpTADblzFyrdTPDnV+Qtv5zzpYKR8WXmu6n2/0ao66Yp1pC/xnNB3p24iFEkgl8/7JdClvkTDpIeh/E5G3RmhQdua4nCRKs4uXvZnFksA+qJCL6aHfCErJQk2D3OR4LL8KeZoWzkk3B0Q+lIfX9M1yzvFw0PxlfG42xiHlUeNHgpPTalxPrYXA28FGZ0mEJysuqoSLmf0H5fV+62HKnbk= X-MS-TrafficTypeDiagnostic: BN6PR12MB1667: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;20:+w33n1IoPj3f09b1wr+mZdAsG2L1jL6sLEVelTE/iEJjjVwEGZRM0x17Fj6kMUWywy4OOqfAiRlpmP8dAibJhRGmMAQMzCvRS0JGX/ypmzjLoXJORNmsIctv/m9L3Ss+WU9YWBqQY6bapw0qgfDgdO+V9eQsFmitUxlp+cUZ00auReFVbqKW2wYLO/7WDfK6Oxa3QT4ZfHphq5OsdlZWFm+tkm9mhOknxSTfbNgVrRAgwlmywMTeKa3kr9THAXZicWXVQZXciZLx2XKyP/tndDv2cEtk/hgm53zh4NnkPVo4CPSOb2CmehTG/5gXTTzwA5EqwKKuD4mOpa1fY4LZEVXdattF7sVpYdeuo0SnpeGwtMVFo+Se2sEhMEKgYo9G3Hv34m+OotLRF9t1vqynn4XyD2/nH7c2hzlxI9d5/DXI5uSiO9EjiVMs2eEv29BlCAnFJHQ3zR+r6v6PK9m7nhg4R2I6r2BU594aoyxXYba4rkOQXCROHd23Rt7Q3LOs;4:O8snx2hV2gdPn7K9Wf0uZD7QunEhlWRswYvxhF2FtNLt0kcBjeeaHJeCfk8hGg323UxzYtPSYvAG9CBqwwCHK2aS412jJDlcJp23V7stlMHmltyMOzNToRkqwonl3MGcCwtK7zNZ8co0fyqmEZN7mhShmWKybvHehpuhr2y5jRljBYQqUlvL4SfCBESot1Iv2l9QJLG2KYNH/u+5KRKoMrX4EY/bZR6UcYaMD6fX4DappkR/H8mpwLI15ZzJXwfMMmvx5iLtnutWtii9JUX/ag== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501075)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041268)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:BN6PR12MB1667;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN6PR12MB1667; X-Forefront-PRVS: 0540846A1D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39380400002)(366004)(376002)(346002)(39860400002)(396003)(199004)(189003)(24454002)(106356001)(105586002)(72206003)(478600001)(53936002)(5660300001)(68736007)(2950100002)(97736004)(50466002)(65826007)(64126003)(65956001)(65806001)(7416002)(6666003)(66066001)(47776003)(316002)(305945005)(6116002)(3846002)(16526018)(31686004)(7736002)(8936002)(36756003)(16576012)(86362001)(58126008)(54906003)(81156014)(230700001)(8676002)(2906002)(83506002)(4326008)(31696002)(6246003)(53546011)(90366009)(76176011)(52116002)(386003)(229853002)(67846002)(2486003)(25786009)(77096006)(6486002)(81166006)(23676004)(52146003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1667;H:[10.236.68.193];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Janakarajan.Natarajan@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxNjY3OzIzOkJlOW8ra3E3NFR6WkNXS2REZzhXeEw0OUVw?= =?utf-8?B?bkFlcjYycmV1T1VjdDRDY2xTanZSK05WMm1RbHlDSVhOZHcwSkt6eW5meGxP?= =?utf-8?B?SkdEeTRFdUJpeE5ON210YXg0Qi9McFNuWXVzb3JHeTNIN2piaklPeEd5N2tr?= =?utf-8?B?S25CUjhrVkJEMVNVUnZFd3JabjFObk0wOW1sR3cyOXoxOVBLNWxJdFQ3MFRq?= =?utf-8?B?cloxZloyZWJEYitPeGZGYkcrN3FIbjE0ejU0eEh2R1hzcDRST3Axc0FIUzVr?= =?utf-8?B?Ti94TTlFRDRXK1lZUnkrNVJJbUhueGtMU1lvaHFSZHJkWW9YSTRqVCtuTDNW?= =?utf-8?B?T1R0eENneWxUOXZ4N2ZvVCtHWEIwQmxoUmZsMjljVStWRyt4ai9jM1IwSzhi?= =?utf-8?B?bkFBOGtCS2tNclliZjRqNXZpUGdKVlNzb3JvKzFQcnltSENmbTdmTDVETi94?= =?utf-8?B?ei9DRnp4RTgxcTRndXFUc2dJT29QSDdneFVYT1pBWWZsT1VURThqSW9hTzRU?= =?utf-8?B?ZVpKc0ZURjgweXRzbjBtVGdGeW4raytZTkdzM1VzNGZkbGR0OWdYa1NPRDA5?= =?utf-8?B?aW1lbVFMRmk1VnBwaVFPd29MRTVObjUwWkRmZmI3RzllNzd2eTRvRnAwNmNL?= =?utf-8?B?OGZhWVFVaDZSdVRHS0c3NGJYZVo0SkJGb21rY29UeGcwaXd0d3N4Wmw3UFNw?= =?utf-8?B?NVIxa29KSUMxdFluRDNtejJOTFJDbHJYQ054dlVvc0Y5enpRSUs3QzNkVFJX?= =?utf-8?B?NHlwVmlIa0pwbERkSTVUQm5CUUFIcm4yUXRGY1AxMnVVd1hZd2dQZzh4aldo?= =?utf-8?B?NW8zVjB0M3kvbm81U0tMa241NEZ0TUlqa3NiUVdVQVNSUVhWMUdVNmVxNXpo?= =?utf-8?B?ZTVwNG01UllveUJqUGxkcHd5SC9tRWxzdklmRmRJWGtlR3lsTXBjOFRZT1o1?= =?utf-8?B?eUR3ZU81WDluRjJTUml1QUJnZE95UHN5Y1IzVXFWVUJnK3RBckVTMFl6enI3?= =?utf-8?B?U1dqTjZzSkptaTJOd3NaQWxXYkdQYVN5cWZLZmRSYnpqcXdTYnFpVGJUZFZI?= =?utf-8?B?aU9CYjZMNzIvbkg2amxBd2lxK1VaNW05R1krY3BYenpxb0YyaHBZc3k2Mi9K?= =?utf-8?B?NHcwTHZNVWZRd3dRV1d4K0dBWmlPbzZuZjdCcVZaa0Jkd08rZkYyQXV3UnNF?= =?utf-8?B?WnF2ZDlXYk5Ic0pSeE9jN29Gb0NkZkh6SlZueU5lYnhoVDJRMlBxSjAweDJt?= =?utf-8?B?QW1IK0VrcHV5ZkJ0VnZrTE11ZVpaZCtVYkxzcGFjY1VzYStEb2hkUzd6VFFO?= =?utf-8?B?UkhBLzhSZ1VUWG4wNXZNSFdnbHNTWEgyL1V2OHdqRXgzZ3l3azRVYWJrSU5m?= =?utf-8?B?SmJNR0pnSDg5LzlLZC9kYmNxVUV2a1poYXlrVTZZV3dIQVgxZ3NmNXFZY05q?= =?utf-8?B?RUlKdjUySlVnM1N3RXZjaEpLSHhLWWZCMFZuZk95dnNsVGNYS0NqcDRJeVFz?= =?utf-8?B?RUtiYjd6STA4SFF3YS94Mmpyc1pGNzFpMDkwM05XWlI2Z3Y2T1NJTzhlNUxH?= =?utf-8?B?bG5uM2cvVDdRYllVMmpyZ3h5T1ErZktDY1RUbWFvamdXSnhuRWU1MW83b0Z4?= =?utf-8?B?UDhwYUFsWWh5bE9FR2Fyc3gyQThSZkNoZnFkaVVuWEQwQXJORnoxbUttNkpI?= =?utf-8?B?dFBoOW50ZHJqeEtOSUdERDM5c3VOTnIxTzNFN0k5VStCMWZYcVBHaUVMMi9v?= =?utf-8?B?cnIwbkdsMlZPUlVoSWNIRnBnb2RsMS8vSGZLZ2k0aHdjT3AwVitqei81bDh0?= =?utf-8?B?bWdpN0VVbUU4R3VkLzRnYTF4NjE2NDllOGJmcHpNWFU4dzlNMkpHQ1VKQWVt?= =?utf-8?B?WGZqbHQvSmJsejFNMkZ4VTY3dEQzU2hkQU0xYXQ3SXE1WEZOcFI2L0kvcGYv?= =?utf-8?B?OStiejNoTWUvY2FEcjRiOEtsV25XaWVKMHdJSFRXUmlUbStrRGZ4WStkcG95?= =?utf-8?Q?tY6PSA?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;6:gWM1IdLFJDsCbKg26vnrvKu1O5n3NUYJD6NLt0YOC+D4Hz4/2fWGlu6gNlNMwOygKOcQnKBJ56q/JZK5sNeWVdCgZj49KUc9Nurp65EXaL1ufSM0r4s7t/3oqKxP64AM2Ln9QNzQLNgqYds5cvFuoDWoZMfq58p4vH75quhcRBS/8+DDuF8EUFm7FxyKBsFl0SHKXBWy6aGhrlhDIO70bDAYO+lARgRKrHZboUcHxAa54Xpa3J2dA7Jlk06eFP5F3rfvZSDcKDN0ZDCJq0V0M5m+Ie8w2uTYMw5ebZmRbHTGssnZf6ciJ8TEtCqJKlHTusIuKZHS2UmVEJwob1b8IdNLZcwtDiN1B0nsQU+q4uY=;5:u76E6OJ8PO/iYLRUPOPkM5yiSprDBYm54goNzCqo2Z47rrDeMBTTSBYNxumrZiXneoqkEpOwVCzwQHwB2roMVNjf4C3fHGAUVle39cn+emZ0YzwZxdhvoJsmwYRUkuCq4Sd3yZTBnAr/wSnzu3JKa8QG9MlCL5KQQddTaUDVcsY=;24:8oBPUHHCsdYyLEu+n0qA9OMTumcTmRMFRcxxFq5zd+lYHzHRvB81a4RhEehsKzCe1rkHzT7dPb7cfvssO8O+tvapR8qKbSKUX1wSjUmeX4o=;7:G5NhnDYtylq0AUOxzOS3EF7DcxBFn++xdERE5LP32gMyuOTdbITG2CAZPI1ddAtWRF+xklCiKJFg/Fi+buG6991+cMYqUZmULfL2aSX9WVRaA0W5oB1gWKV8xPdZ7CCWp0HHkTdPFCRhuD56XmgCWFEFuyPpFqQmrtG3RnIQtIoAiBsoMkwa7MqBDk5DugAOD609WaFAg/5mLyT3XwARjDPUCw0e46wOLF4V5E7fVvbpiNLDm+sLFLCJvpY0xtCW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;20:98uR0IZPZotSAfnjz/KiKmZawhdDEd44Sl5Gm46fz73ydvW0M/AhcBJC0CvHSY17V8IzwL9NEia4UTZfl27FWvDYJwBNuI0Fwu+wftC4pHhAO0jdRvrCM9SpSJgRycc3PWIyXpmSzhvfJzqN/MzXT1d/TNLT0QDfZhkKQXNWaRxieSv/YVB4h33w/fLp939ewQr+dX1oVwiFvK4pR1eXbSG3rvsqFuid2owNyLw6ks+ZPIem0eFY713GYciG+oTV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2018 23:55:37.6910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f63ece4-9fcf-435d-4fb7-08d5523c53c7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1667 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/8/2017 4:39 PM, Janakarajan Natarajan wrote: > This patchset adds support for Perf Extension on AMD KVM guests. > > When perf runs on a guest with family = 15h || 17h, the MSRs that are > accessed, when the Perf Extension flag is made available, differ from > the existing K7 MSRs. The accesses are to the AMD Core Performance > Extension counters which provide 2 extra counters and new MSRs for both > the event select and counter registers. > > Since the new event select and counter MSRs are interleaved and K7 MSRs > are contiguous, the logic to map them to the gp_counters[] is changed. > > This patchset has been tested with Family 17h and Opteron G1 guests. > > v1->v2: > * Rearranged MSR #defines based on Boris's suggestion. > > v2->v3: > * Changed the logic of mapping MSR to gp_counters[] index based on > Boris's feedback. > * Removed use of family checks based on Radim's feedback. > * Removed KVM bugfix patch since it is already applied. > > Janakarajan Natarajan (3): > x86/msr: Add AMD Core Perf Extension MSRs > x86/kvm: Add support for AMD Core Perf Extension in guest > x86/kvm: Expose AMD Core Perf Extension flag to guests Are there any concerns regarding this patchset? > > arch/x86/include/asm/msr-index.h | 14 ++++ > arch/x86/kvm/cpuid.c | 8 ++- > arch/x86/kvm/pmu_amd.c | 140 +++++++++++++++++++++++++++++++++++---- > arch/x86/kvm/x86.c | 1 + > 4 files changed, 148 insertions(+), 15 deletions(-) >