From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26E4C43331 for ; Mon, 30 Mar 2020 01:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AE74206F6 for ; Mon, 30 Mar 2020 01:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728113AbgC3BY5 (ORCPT ); Sun, 29 Mar 2020 21:24:57 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:57282 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727830AbgC3BY5 (ORCPT ); Sun, 29 Mar 2020 21:24:57 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 48rFBD6LBGz1qrFS; Mon, 30 Mar 2020 03:24:52 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 48rFBD42WBz1r0bl; Mon, 30 Mar 2020 03:24:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Fvub03wl5HIX; Mon, 30 Mar 2020 03:24:51 +0200 (CEST) X-Auth-Info: od+I4xl5ut2Q/YmRdmMDkY5JVWT6qwkF+EZ0I+fyrGA= Received: from [IPv6:::1] (unknown [195.140.253.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 30 Mar 2020 03:24:51 +0200 (CEST) Subject: Re: [03/12] bus: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver To: Christophe Kerello , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, tony@atomide.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <1584975532-8038-1-git-send-email-christophe.kerello@st.com> <1584975532-8038-4-git-send-email-christophe.kerello@st.com> From: Marek Vasut Message-ID: Date: Mon, 30 Mar 2020 03:24:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1584975532-8038-4-git-send-email-christophe.kerello@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/20 3:58 PM, Christophe Kerello wrote: > The driver adds the support for the STMicroelectronics FMC2 EBI controller > found on STM32MP SOCs. > On DH STM32MP1 SoM in PDK2 carrier board, Tested-by: Marek Vasut btw. it seems this sets BTRx DATLAT and CLKDIV to 0xf , it's "Don't care" in the datasheet for Muxed mode, but then it should probably be set to 0. The bindings I used are below: &fmc { pinctrl-names = "default", "sleep"; pinctrl-0 = <&fmc_pins_b>; pinctrl-1 = <&fmc_sleep_pins_b>; status = "okay"; #address-cells = <1>; #size-cells = <1>; /delete-property/interrupts; /delete-property/dmas; /delete-property/dma-names; reg = <0x58002000 0x1000>; ranges; ebi { #address-cells = <2>; #size-cells = <1>; compatible = "st,stm32mp1-fmc2-ebi"; ranges = <0 0 0x60000000 0x4000000>, <1 0 0x64000000 0x4000000>, <2 0 0x68000000 0x4000000>, <3 0 0x6c000000 0x4000000>; ksz8851: ks8851mll@0,0 { compatible = "micrel,ks8851-mll"; reg = <1 0x0 0x2 1 0x2 0x20000>; interrupt-parent = <&gpioc>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; bank-width = <2>; /* Timing values are in nS */ st,fmc2_ebi_cs_mux_enable; st,fmc2_ebi_cs_transaction_type = <4>; st,fmc2_ebi_cs_buswidth = <16>; st,fmc2_ebi_cs_address_setup = <6>; st,fmc2_ebi_cs_address_hold = <6>; st,fmc2_ebi_cs_data_setup = <127>; st,fmc2_ebi_cs_bus_turnaround = <9>; st,fmc2_ebi_cs_data_hold = <9>; }; sram@3,0 { compatible = "mtd-ram"; reg = <3 0x0 0x80000>; bank-width = <2>; /* Timing values are in nS */ st,fmc2_ebi_cs_mux_enable; st,fmc2_ebi_cs_transaction_type = <4>; st,fmc2_ebi_cs_buswidth = <16>; st,fmc2_ebi_cs_address_setup = <6>; st,fmc2_ebi_cs_address_hold = <6>; st,fmc2_ebi_cs_data_setup = <127>; st,fmc2_ebi_cs_bus_turnaround = <9>; st,fmc2_ebi_cs_data_hold = <9>; }; }; };