From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15212C433F5 for ; Mon, 25 Apr 2022 20:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234273AbiDYUGU (ORCPT ); Mon, 25 Apr 2022 16:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245106AbiDYUGM (ORCPT ); Mon, 25 Apr 2022 16:06:12 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2162128CCC for ; Mon, 25 Apr 2022 13:03:07 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id d3so10069446ilr.10 for ; Mon, 25 Apr 2022 13:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6IUFVGvfVxw7l6YMhU424l8XqBpC7fGs6gju1QrjU6I=; b=b3u4xyXqePElE6uzOsARKY8+PI4TX3Kfwz1v+pt+aDBG6YYxf8B4BFF122dVgsWa0G wTroXZKBEgXygfLWgFZ6duEffBwEcqbKlxo2oXvU6f5+c465slS+cKlD6utjJ9VRtGKz E23GQlTrmCfcHJ2Lo22SWt5mHhkrQ8ecf4i5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6IUFVGvfVxw7l6YMhU424l8XqBpC7fGs6gju1QrjU6I=; b=XZM0NqrhcA0bpz5gaUEK1H8CnfFkBhAXBZ2vkMfBItv17TCFRA5JsIgntBnEhRnpEf 4iMrEBdsU23Td8LMKGWCpsZpSp3Qbt+Lf7ZxIaMDILIi89ioCMeqgqMf+R8OZv3+UWPU SLkayCIetB8g4LsyFxRCvl6Y/Tuph8J8kxG7GGtaCkqDAE11cfB+42UvXrG2w7k04qvl qAUEwLQArnoxSFhpwja54AR8mFSUY4rEo7UQkPFffeCWGE6zpHPgDMAK++zAwafu7/7d rb6etVxHgyfDvBQcVOqUI65YH+4YB77LlT9wOHmk01fpwwfPWLvnpkOeHeCHMn0j7+QV Y2gw== X-Gm-Message-State: AOAM5313ak1jF992t0QT6mwUXmwSgtqg3fCsRDumJNbq3Z10oo8tpSd5 Co9wDWvwq6nWrdteDefL91sgNw== X-Google-Smtp-Source: ABdhPJz7jabMcQMahAgzEB+tpsiYw2q8m1KcTY1nfihf3Zk6kiyb14v45rF0wOE1m6bpHahdMHyESw== X-Received: by 2002:a05:6e02:190c:b0:2cd:9331:2750 with SMTP id w12-20020a056e02190c00b002cd93312750mr3026582ilu.214.1650916987125; Mon, 25 Apr 2022 13:03:07 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id s8-20020a056e021a0800b002cd8179e7a0sm5202881ild.16.2022.04.25.13.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 13:03:06 -0700 (PDT) Subject: Re: [PATCH RESEND] selftests/damon: add damon to selftests root Makefile To: Yuanchu Xie , SeongJae Park Cc: Shuah Khan , Markus Boehme , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , David Rientjes References: <20220418202017.3583638-1-yuanchu@google.com> <93c3f9b4-7e14-858b-bf6c-23e4f3bec232@google.com> <31edb348-d802-0ee5-c13d-a9ef17b2ea8a@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Mon, 25 Apr 2022 14:03:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <31edb348-d802-0ee5-c13d-a9ef17b2ea8a@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/22 1:37 PM, Shuah Khan wrote: > On 4/24/22 1:35 PM, David Rientjes wrote: >> On Mon, 18 Apr 2022, Yuanchu Xie wrote: >> >>> Currently the damon selftests are not built with the rest of the >>> selftests. We add damon to the list of targets. >>> >>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests") >>> Reviewed-by: SeongJae Park >>> Signed-off-by: Yuanchu Xie >> >> Acked-by: David Rientjes >> > > Thank you. Applied to linux-kselftest next for 5.19-rc1. > The test builds with warnings. Would you like to fix these as well? make gcc huge_count_read_write.c -o linux_5.18/tools/testing/selftests/damon/huge_count_read_write huge_count_read_write.c: In function ‘write_read_with_huge_count’: huge_count_read_write.c:23:9: warning: ‘write’ reading 4294967295 bytes from a region of size 1 [-Wstringop-overread] 23 | write(filedesc, "", 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:378:16: note: in a call to function ‘write’ declared with attribute ‘access (read_only, 2, 3)’ 378 | extern ssize_t write (int __fd, const void *__buf, size_t __n) __wur | ^~~~~ huge_count_read_write.c:25:15: warning: ‘read’ writing 4294967295 bytes into a region of size 25 overflows the destination [-Wstringop-overflow=] 25 | ret = read(filedesc, buf, 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ huge_count_read_write.c:14:14: note: destination object ‘buf’ of size 25 14 | char buf[25]; | ^~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:371:16: note: in a call to function ‘read’ declared with attribute ‘access (write_only, 2, 3)’ 371 | extern ssize_t read (int __fd, void *__buf, size_t __nbytes) __wur | ^~~~ thanks, -- Shuah