From: Mario Limonciello <mario.limonciello@amd.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-integrity@vger.kernel.org,
Jerry Snitselaar <jsnitsel@redhat.com>,
stable@vger.kernel.org, Todd Brandt <todd.e.brandt@intel.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Ronan Pigott <ronan@rjp.ie>, Raymond Jay Golo <rjgolo@gmail.com>
Subject: Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs
Date: Sun, 27 Aug 2023 19:35:00 -0500 [thread overview]
Message-ID: <f6d75cac-2556-484e-8a2c-3531b24b1ca5@amd.com> (raw)
In-Reply-To: <CV3J3TCMB74C.1WA96NQ9J593U@suppilovahvero>
On 8/27/2023 13:12, Jarkko Sakkinen wrote:
> On Wed Aug 23, 2023 at 9:58 PM EEST, Mario Limonciello wrote:
>> On 8/23/2023 12:40, Jarkko Sakkinen wrote:
>>> On Wed Aug 23, 2023 at 11:23 AM EEST, Paul Menzel wrote:
>>>> Dear Jarkko,
>>>>
>>>>
>>>> Thank you for your patch.
>>>>
>>>>
>>>> Am 23.08.23 um 01:15 schrieb Jarkko Sakkinen:
>>>>> The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for
>>>>> all AMD fTPMs") doesn't work properly on a number of Intel fTPMs. On the
>>>>> reported systems the TPM doesn't reply at bootup and returns back the
>>>>> command code. This makes the TPM fail probe.
>>>>>
>>>>> Since only Microsoft Pluton is the only known combination of AMD CPU and
>>>>> fTPM from other vendor, disable hwrng otherwise. In order to make sysadmin
>>>>> aware of this, print also info message to the klog.
>>>>>
>>>>> Cc: stable@vger.kernel.org
>>>>> Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs")
>>>>> Reported-by: Todd Brandt <todd.e.brandt@intel.com>
>>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804
>>>>> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>>>>
>>>> Mario’s patch also had the three reporters below listed:
>>>>
>>>> Reported-by: Patrick Steinhardt <ps@pks.im>
>>>> Reported-by: Ronan Pigott <ronan@rjp.ie>
>>>> Reported-by: Raymond Jay Golo <rjgolo@gmail.com>
>>>
>>> The problem here is that checkpatch throws three warnings:
>>>
>>> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
>>> #19:
>>> Reported-by: Patrick Steinhardt <ps@pks.im>
>>> Reported-by: Ronan Pigott <ronan@rjp.ie>
>>>
>>> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
>>> #20:
>>> Reported-by: Ronan Pigott <ronan@rjp.ie>
>>> Reported-by: Raymond Jay Golo <rjgolo@gmail.com>
>>>
>>> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
>>> #21:
>>> Reported-by: Raymond Jay Golo <rjgolo@gmail.com>
>>> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>>>
>>
>> FWIW I observed the same checkpatch warning when I submitted my version
>> of the patch. I figured it's better to ignore the warning and attribute
>> everyone who reported the issue affected them.
>
> OK so:
>
> 1. checkpatch.pl is part of the kernel process.
> 2. Bugzilla is not part of the kernel process.
>
> Why emphasis on 1?
>
> BR, Jarkko
The reason I submitted it this way is because of this quote from the
documentation [1].
"Check your patches with the patch style checker prior to submission
(scripts/checkpatch.pl). Note, though, that the style checker should be
viewed as a guide, not as a replacement for human judgment. If your code
looks better with a violation then its probably best left alone."
I wanted the patch to capture and attribute all those that reported it
not just the "first one". Like I said previously, it's better to have a
collection of people to ping to notify if something needs to be reverted.
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#style-check-your-changes
next prev parent reply other threads:[~2023-08-28 0:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 23:15 [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs Jarkko Sakkinen
2023-08-23 8:23 ` Paul Menzel
2023-08-23 17:40 ` Jarkko Sakkinen
2023-08-23 18:58 ` Mario Limonciello
2023-08-27 18:12 ` Jarkko Sakkinen
2023-08-28 0:35 ` Mario Limonciello [this message]
2023-08-29 8:38 ` Linux regression tracking (Thorsten Leemhuis)
2023-09-01 8:49 ` Thorsten Leemhuis
2023-09-04 22:32 ` Jarkko Sakkinen
2023-09-05 12:01 ` Thorsten Leemhuis
2023-09-11 10:40 ` Jarkko Sakkinen
2023-09-11 10:42 ` Jarkko Sakkinen
2023-09-04 18:00 ` Jarkko Sakkinen
2023-09-04 18:18 ` Jarkko Sakkinen
2023-08-23 19:24 ` checkpatch complains about Reported-by block (was: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs) Paul Menzel
2023-08-24 4:43 ` Joe Perches
2023-08-27 18:29 ` Jarkko Sakkinen
2023-08-27 18:26 ` Jarkko Sakkinen
2023-08-28 1:05 ` [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs Jerry Snitselaar
2023-08-29 19:03 ` Jerry Snitselaar
2023-08-30 18:25 ` Jerry Snitselaar
2023-09-04 20:51 ` Jarkko Sakkinen
2023-09-04 18:12 ` [PATCH v4] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6d75cac-2556-484e-8a2c-3531b24b1ca5@amd.com \
--to=mario.limonciello@amd.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=ps@pks.im \
--cc=rjgolo@gmail.com \
--cc=ronan@rjp.ie \
--cc=stable@vger.kernel.org \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).