From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933346AbcHYJn0 (ORCPT ); Thu, 25 Aug 2016 05:43:26 -0400 Received: from mout.web.de ([212.227.17.11]:57699 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756052AbcHYJnW (ORCPT ); Thu, 25 Aug 2016 05:43:22 -0400 To: linux-efi@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Ingo Molnar , Matt Fleming , Thomas Gleixner Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] x86/efi: Use kmalloc_array() in efi_call_phys_prolog() Message-ID: Date: Thu, 25 Aug 2016 11:40:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:EWDyVDHUpE1cdlh2pPwDeSANresxYyyykBi9qdgdn7x9gTnWRxj hLSWL1+3C/zG1Mo+zu2dPoBY1fJW/pMw1jhbZcI+K2mauuCLBOcJsWI1EdJSFpb2ofSVr4l ApSF3T8EQkH3VK2tBgZWG6bgRQAHFEN8VIagz6i45sFHYl2JdE+yxoA4R+SdnANnR8rqay1 0mj54HZElvgLITi/z3j5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:5NQrI43b1o4=:TAD+1zbBn+oEIZdiKE5Ke0 sPDmQpKnmMwqOtvjVD9Chwa0OTKVwwUq7OtNmttaQAguBD5nO1V3O+uJ03n8l/uN69aZyykM1 PKaVG2CMF4zPM7H25iCrh/BMVlpumKiVu06RdXDjLN5miPbC1yPDmx9WXN7RV/WTKtphaAvHK 7qbhPyN2Yb86Qdf5LTKUf8Tjxm+tdcLk73BgTpuTCW9Y3VcMLcdO93vf/N7vKJurQpaHFoEXq lR3HvuV0w7wALxg4nMOAPN1K5UuBZbaLRMebuO1PQgFpIlwz+w84/agd/c3oZ8UmVsObdHt/n DqJ/oquzHiIhzOe5vtG40fFi48BxROKCSAyqDC8+yEb8JJMgSx0R4btwYsQPL15n9uhkFybVB mVgq4wm8ioOQmO3qIssSJx6lpXCIxlgkxLzXBS83z9xhTcuEWYosjyyNlSdMKfWbGulg+ztYA jAAdQxlzqzkaSZzNZFqs650sphjrRV9dRlmR/i6jOewIWESQQOiT+/pLtwQATnmRpD7pTKffP 9zPi5qELDnVA7ErqBiwfYySqMo/UFzIo5nPdwj7lMZjZsbi+eAe07U6F/f130q1PKfAEGfuGM tT9omy4LtquYQJ4i6UN8YUFYWjYQLWqeLwMxS5/Fuc9N+vUP1WEqdVjXeqGrzBYdHIeD+9a9p EQB+UZHTggavlHR2J7KGKYH+U70piDNRCc/JgdCqDbontR80z/JRtkGFTapZ6rS6KnSU25bLU R0Brgm6U71700+U/OEksT1ppkx/LCH1rDXqQD4dnzugyPZ94uFCCDLFqvTH8DzJP7ou5DLlQf /SGIyilPkiWWt4BAYzHNaFGZjOIdg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 11:34:03 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/x86/platform/efi/efi_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c index 677e29e..311022a 100644 --- a/arch/x86/platform/efi/efi_64.c +++ b/arch/x86/platform/efi/efi_64.c @@ -85,7 +85,7 @@ pgd_t * __init efi_call_phys_prolog(void) early_code_mapping_set_exec(1); n_pgds = DIV_ROUND_UP((max_pfn << PAGE_SHIFT), PGDIR_SIZE); - save_pgd = kmalloc(n_pgds * sizeof(pgd_t), GFP_KERNEL); + save_pgd = kmalloc_array(n_pgds, sizeof(*save_pgd), GFP_KERNEL); for (pgd = 0; pgd < n_pgds; pgd++) { save_pgd[pgd] = *pgd_offset_k(pgd * PGDIR_SIZE); -- 2.9.3