From: Peter Rosin <peda@axentia.se>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH RFC v3 1/4] dt-bindings: mux: Increase the number of arguments in mux-controls
Date: Mon, 29 Nov 2021 09:15:56 +0100 [thread overview]
Message-ID: <f6e8cec9-4d74-dda5-d56a-b55ebfadf30a@axentia.se> (raw)
In-Reply-To: <5f455c4d-5edb-4382-1193-a519a7a227a5@ti.com>
On 2021-11-29 05:36, Aswath Govindraju wrote:
> Hi Peter,
>
> On 25/11/21 7:05 pm, Peter Rosin wrote:
>> Hi!
>>
>> You need to have some description on how #mux-control-cells now work.
>> The previous description is in mux-consumer.yaml and an update there
>> is needed.
>>
>> However, I have realized that the adg792a binding uses #mux-control-cells
>> to indicate if it should expose its three muxes with one mux-control
>> and operate the muxes in parallel, or if it should be expose three
>> independent mux-controls. So, the approach in this series to always
>> have the #mux-control-cells property fixed at <2> when indicating a
>> state will not work for that binding. And I see no fix for that binding
>> without adding a new property.
>>
>> So, I would like a different approach. Since I dislike how mux-controls
>> -after this series- is not (always) specifying a mux-control like the name
>> says, but instead optionally a specific state, the new property I would
>> like to add is #mux-state-cells such that it would always be one more
>> than #mux-control-cells.
>>
>> mux: mux-controller {
>> compatible = "gpio-mux";
>> #mux-control-cells = <0>;
>> #mux-state-cells = <1>;
>>
>> mux-gpios = <...>;
>> };
>>
>> can-phy {
>> compatible = "ti,tcan1043";
>> ...
>> mux-states = <&mux 1>;
>> };
>>
>> That solves the naming issue, the unused argument for mux-conrtrollers
>> that previously had #mux-control-cells = <0>, and the binding for adg792a
>> need no longer be inconsistent.
>>
>> Or, how should this be solved? I'm sure there are other options...
>>
>
>
> I feel that the new approach using mux-state-cells seems to be
> overpopulating the device tree nodes, when the state can be represented
> using the control cells. I understand that the definition for
> mux-controls is to only specify the control line to be used in a given
> mux. Can't it now be upgraded to also represent the state at which the
> control line has to be set to?
>
> With respect to adg792a, it is inline with the current implementation
> and the only change I think would be required in the driver is,
No, that does not work. See below.
>
> diff --git a/drivers/mux/adg792a.c b/drivers/mux/adg792a.c
> index e8fc2fc1ab09..2cd3bb8a40d4 100644
> --- a/drivers/mux/adg792a.c
> +++ b/drivers/mux/adg792a.c
> @@ -73,8 +73,6 @@ static int adg792a_probe(struct i2c_client *i2c)
> ret = device_property_read_u32(dev, "#mux-control-cells", &cells);
> if (ret < 0)
> return ret;
> - if (cells >= 2)
> - return -EINVAL;
>
> mux_chip = devm_mux_chip_alloc(dev, cells ? 3 : 1, 0);
When you add cell #2 with the state, the cells variable will end up
as 2 always. Which means that there is no way to alloc one mux
control since "cells ? 3 : 1" will always end up as "3", with no
easy fix.
So, your approach does not work for this driver.
Cheers,
Peter
> if (IS_ERR(mux_chip))
>
> And the following series should be compatible with it. If adg792a driver
> is the only issue then would there be any issue with only changing it
> and using this implementation?
>
> Thanks,
> Aswath
>
>
>
>
>> Cheers,
>> Peter
>>
>> On 2021-11-23 09:12, Aswath Govindraju wrote:
>>> Increase the allowed number of arguments in mux-controls to add support for
>>> passing information regarding the state of the mux to be set, for a given
>>> device.
>>>
>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>>> ---
>>> Documentation/devicetree/bindings/mux/gpio-mux.yaml | 2 +-
>>> Documentation/devicetree/bindings/mux/mux-controller.yaml | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>>> index 0a7c8d64981a..c810b7df39de 100644
>>> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>>> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>>> @@ -26,7 +26,7 @@ properties:
>>> List of gpios used to control the multiplexer, least significant bit first.
>>>
>>> '#mux-control-cells':
>>> - const: 0
>>> + enum: [ 0, 1, 2 ]
>>>
>>> idle-state:
>>> default: -1
>>> diff --git a/Documentation/devicetree/bindings/mux/mux-controller.yaml b/Documentation/devicetree/bindings/mux/mux-controller.yaml
>>> index 736a84c3b6a5..0b4b067a97bf 100644
>>> --- a/Documentation/devicetree/bindings/mux/mux-controller.yaml
>>> +++ b/Documentation/devicetree/bindings/mux/mux-controller.yaml
>>> @@ -73,7 +73,7 @@ properties:
>>> pattern: '^mux-controller(@.*|-[0-9a-f]+)?$'
>>>
>>> '#mux-control-cells':
>>> - enum: [ 0, 1 ]
>>> + enum: [ 0, 1, 2 ]
>>>
>>> idle-state:
>>> $ref: /schemas/types.yaml#/definitions/int32
>>>
>
next prev parent reply other threads:[~2021-11-29 8:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 8:12 [PATCH RFC v3 0/4] MUX: Add support for reading enable state from DT Aswath Govindraju
2021-11-23 8:12 ` [PATCH RFC v3 1/4] dt-bindings: mux: Increase the number of arguments in mux-controls Aswath Govindraju
2021-11-25 13:35 ` Peter Rosin
2021-11-29 4:36 ` Aswath Govindraju
2021-11-29 8:15 ` Peter Rosin [this message]
2021-11-29 9:31 ` Aswath Govindraju
2021-11-29 12:28 ` Peter Rosin
2021-11-29 12:55 ` Aswath Govindraju
2021-11-23 8:12 ` [PATCH RFC v3 2/4] dt-bindings: phy: ti,tcan104x-can: Document mux-controls property Aswath Govindraju
2021-11-23 8:12 ` [PATCH RFC v3 3/4] mux: Add support for reading mux enable state from DT Aswath Govindraju
2021-11-25 13:52 ` Peter Rosin
2021-11-29 4:44 ` Aswath Govindraju
2021-11-29 8:36 ` Peter Rosin
2021-11-30 5:44 ` Aswath Govindraju
2021-11-30 5:58 ` Aswath Govindraju
2021-11-30 8:11 ` Peter Rosin
2021-11-23 8:12 ` [PATCH RFC v3 4/4] phy: phy-can-transceiver: Add support for setting mux Aswath Govindraju
2021-11-25 14:07 ` Peter Rosin
2021-11-29 4:51 ` Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6e8cec9-4d74-dda5-d56a-b55ebfadf30a@axentia.se \
--to=peda@axentia.se \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).