From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
jgross@suse.com, linux@armlinux.org.uk, robin.murphy@arm.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
Date: Mon, 14 Jan 2019 18:27:53 -0500 [thread overview]
Message-ID: <f6eef305-daf3-dad8-96e3-d2f93d169fd4@oracle.com> (raw)
In-Reply-To: <20190111151235.GA2836@jordon-HP-15-Notebook-PC>
On 1/11/19 10:12 AM, Souptick Joarder wrote:
> Convert to use vm_insert_range() to map range of kernel
> memory to user vma.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
(although it would be good to mention in the commit that you are also
replacing count with vma_pages(vma), and why)
> ---
> drivers/xen/gntdev.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index b0b02a5..ca4acee 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> {
> struct gntdev_priv *priv = flip->private_data;
> int index = vma->vm_pgoff;
> - int count = vma_pages(vma);
> struct gntdev_grant_map *map;
> - int i, err = -EINVAL;
> + int err = -EINVAL;
>
> if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
> return -EINVAL;
>
> pr_debug("map %d+%d at %lx (pgoff %lx)\n",
> - index, count, vma->vm_start, vma->vm_pgoff);
> + index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
>
> mutex_lock(&priv->lock);
> - map = gntdev_find_map_index(priv, index, count);
> + map = gntdev_find_map_index(priv, index, vma_pages(vma));
> if (!map)
> goto unlock_out;
> if (use_ptemod && map->vma)
> @@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> goto out_put_map;
>
> if (!use_ptemod) {
> - for (i = 0; i < count; i++) {
> - err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
> - map->pages[i]);
> - if (err)
> - goto out_put_map;
> - }
> + err = vm_insert_range(vma, map->pages, map->count);
> + if (err)
> + goto out_put_map;
> } else {
> #ifdef CONFIG_X86
> /*
next prev parent reply other threads:[~2019-01-14 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 15:12 [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range Souptick Joarder
2019-01-14 23:27 ` Boris Ostrovsky [this message]
2019-01-15 4:49 ` Souptick Joarder
2019-01-15 15:29 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2018-11-15 15:51 Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6eef305-daf3-dad8-96e3-d2f93d169fd4@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jgross@suse.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mhocko@suse.com \
--cc=robin.murphy@arm.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).