From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/6] x86/microcode/AMD: Add microcode container data checking functions
Date: Tue, 1 May 2018 18:19:15 +0200 [thread overview]
Message-ID: <f716fae6-f28c-d09d-3bb6-d20676c56683@maciej.szmigiero.name> (raw)
In-Reply-To: <20180501081819.GB31863@pd.tnic>
On 01.05.2018 10:18, Borislav Petkov wrote:
> On Tue, May 01, 2018 at 12:27:17AM +0200, Maciej S. Szmigiero wrote:
>> These checking functions are supposed to be called in order:
>
> We don't do magical rules like that - you either verify fully and
> correctly or you don't bother at all. And since you're adamant that this
> verification needs to happen, then please do it completely.
>
These are internal functions to this driver, declared as "static", so
there is no problem if they have additional requirements with respect
to their call order.
But it is, of course, possible to do these checks also in the later
checking functions as you wish.
Maciej
next prev parent reply other threads:[~2018-05-01 16:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:34 [PATCH v5 0/6] x86/microcode/AMD: Check microcode file sanity before loading it Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 1/6] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 2/6] x86/microcode/AMD: Add microcode container data checking functions Maciej S. Szmigiero
2018-04-30 9:04 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:18 ` Borislav Petkov
2018-05-01 16:19 ` Maciej S. Szmigiero [this message]
2018-04-23 21:34 ` [PATCH v5 3/6] x86/microcode/AMD: Check microcode container data in the early loader Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:44 ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:43 ` Borislav Petkov
2018-05-01 16:19 ` Maciej S. Szmigiero
2018-05-01 20:03 ` Borislav Petkov
2018-05-02 0:47 ` Maciej S. Szmigiero
2018-05-03 10:01 ` Borislav Petkov
2018-05-03 23:26 ` Maciej S. Szmigiero
2018-05-07 16:35 ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 5/6] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 6/6] x86/microcode/AMD: Check the equivalence table size when scanning it Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f716fae6-f28c-d09d-3bb6-d20676c56683@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).