From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822F9ECDE43 for ; Thu, 18 Oct 2018 12:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A78C2145D for ; Thu, 18 Oct 2018 12:40:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A78C2145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbeJRUlQ (ORCPT ); Thu, 18 Oct 2018 16:41:16 -0400 Received: from hermes.aosc.io ([199.195.250.187]:56387 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbeJRUlQ (ORCPT ); Thu, 18 Oct 2018 16:41:16 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 9B08B15D3E0; Thu, 18 Oct 2018 12:40:18 +0000 (UTC) Message-ID: Subject: Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding From: Icenowy Zheng To: Laurent Pinchart Cc: devicetree@vger.kernel.org, Archit Taneja , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , linux-sunxi@googlegroups.com, Rob Herring , Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Date: Thu, 18 Oct 2018 20:40:11 +0800 In-Reply-To: <2778638.na8ndVNUfi@avalon> References: <20181018073327.64942-1-icenowy@aosc.io> <1886367.eljNk7jKYl@avalon> <2778638.na8ndVNUfi@avalon> Organization: Anthon Open-Source Community Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2018-10-18四的 14:23 +0300，Laurent Pinchart写道： > Hi Icenowy, > > On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote: > > 在 2018-10-18四的 11:53 +0300，Laurent Pinchart写道： > > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote: > > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter > > > > designed > > > > for portable devices. > > > > > > > > Add a binding document for it. > > > > > > > > Signed-off-by: Icenowy Zheng > > > > --- > > > > > > > > .../bindings/display/bridge/anx6345.txt | 39 > > > > +++++++++++++++++++ > > > > > > > > 1 file changed, 39 insertions(+) > > > > create mode 100644 > > > > > > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > new > > > > file > > > > mode 100644 > > > > index 000000000000..0689d4eb5f65 > > > > --- /dev/null > > > > +++ > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > @@ -0,0 +1,39 @@ > > > > +Analogix ANX6345 eDP Transmitter > > > > +-------------------------------- > > > > + > > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter > > > > designed > > > > for > > > > +portable devices. > > > > + > > > > +Required properties: > > > > + > > > > + - compatible : "analogix,anx6345" > > > > + - reg : I2C address of the device > > > > + - reset-gpios : Which GPIO to use for reset > > > > + > > > > +Optional properties: > > > > + > > > > + - dvdd12-supply : Regulator for 1.2V digital core > > > > power. > > > > + - dvdd25-supply : Regulator for 2.5V digital core > > > > power. > > > > > > Shouldn't these to supplies be mandatory ? > > > > Yes they should. > > > > > > + - panel-supply : Regulator for the power of > > > > the panel. > > > > > > Shouldn't the panel supply for specified in the DT node of the > > > panel > > > ? > > > > However, eDP panel can be probed, may vary on the same device, and > > we > > don't have a generic binding for it... > > Shouldn't we fix that ? :-) Maybe we should create a connector binding instead of a panel binding? > > > > > + - edid : verbatim EDID data block > > > > describing > > > > attached > > > > + panel, only used when the panel has > > > > no EDID > > > > info. > > > > > > This should also be specified in the panel DT node. > > > > > > > + - Video port for RGB input, using the DT bindings defined in > > > > [1]. > > > > > > I think you should also add a port for the output. > > > > What will it point to? > > The panel DT node ? > > > > > +[1]: Documentation/devicetree/bindings/media/video- > > > > interfaces.txt > > > > + > > > > +Example: > > > > + > > > > +anx6345: anx6345@38 { > > > > + compatible = "analogix,anx6345"; > > > > + reg = <0x38>; > > > > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > > > > + panel-supply = <®_dc1sw>; > > > > + dvdd25-supply = <®_dldo2>; > > > > + dvdd12-supply = <®_fldo1>; > > > > + > > > > + port { > > > > + anx6345_in: endpoint { > > > > + remote-endpoint = <&tcon0_out_anx6345>; > > > > + }; > > > > + }; > > > > +}; > >