* [PATCH] phy: tegra: should select USB_PHY
@ 2020-03-18 15:23 Corentin Labbe
2020-03-23 3:39 ` Nagarjuna Kristam
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2020-03-18 15:23 UTC (permalink / raw)
To: jonathanh, kishon, nkristam, thierry.reding, treding
Cc: linux-kernel, linux-tegra, Corentin Labbe, stable
I have hit the following build error:
armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister':
xusb.c:(.text+0x2ac): undefined reference to `usb_remove_phy'
armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_setup_ports':
xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev'
PHY_TEGRA_XUSB should select USB_PHY
Fixes: 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/phy/tegra/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
index df07c4dea059..a208aca4ba7b 100644
--- a/drivers/phy/tegra/Kconfig
+++ b/drivers/phy/tegra/Kconfig
@@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB
tristate "NVIDIA Tegra XUSB pad controller driver"
depends on ARCH_TEGRA
select USB_CONN_GPIO
+ select USB_PHY
help
Choose this option if you have an NVIDIA Tegra SoC.
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: tegra: should select USB_PHY
2020-03-18 15:23 [PATCH] phy: tegra: should select USB_PHY Corentin Labbe
@ 2020-03-23 3:39 ` Nagarjuna Kristam
0 siblings, 0 replies; 2+ messages in thread
From: Nagarjuna Kristam @ 2020-03-23 3:39 UTC (permalink / raw)
To: Corentin Labbe, jonathanh, kishon, thierry.reding, treding
Cc: linux-kernel, linux-tegra, stable
Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com>
On 18-03-2020 20:53, Corentin Labbe wrote:
> External email: Use caution opening links or attachments
>
>
> I have hit the following build error:
> armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister':
> xusb.c:(.text+0x2ac): undefined reference to `usb_remove_phy'
> armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_setup_ports':
> xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev'
>
> PHY_TEGRA_XUSB should select USB_PHY
>
> Fixes: 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/phy/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
> index df07c4dea059..a208aca4ba7b 100644
> --- a/drivers/phy/tegra/Kconfig
> +++ b/drivers/phy/tegra/Kconfig
> @@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB
> tristate "NVIDIA Tegra XUSB pad controller driver"
> depends on ARCH_TEGRA
> select USB_CONN_GPIO
> + select USB_PHY
> help
> Choose this option if you have an NVIDIA Tegra SoC.
>
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-23 3:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 15:23 [PATCH] phy: tegra: should select USB_PHY Corentin Labbe
2020-03-23 3:39 ` Nagarjuna Kristam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).