From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECA5C43467 for ; Tue, 13 Oct 2020 18:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A8D1253A0 for ; Tue, 13 Oct 2020 18:03:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pOMe11T9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbgJMSDR (ORCPT ); Tue, 13 Oct 2020 14:03:17 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56464 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgJMSDR (ORCPT ); Tue, 13 Oct 2020 14:03:17 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09DI3FB6092528; Tue, 13 Oct 2020 13:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602612195; bh=UJlIe/Y1UnEj2EVL0fmpbETtgVopdOZvwXEzD5BF4c8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pOMe11T9VGOqTRis3/P3Bwa5riOG0rlluSij32nhFZm0QRgRfzwSvirnKUn3LOmHS O372Kyq/fW5guNBiDxLyo2FfhlzgaHy1/2NpcD39yVwGg8/wQY6W2iZvjJ1BrZnZ8J fC6mBev8/H+trZCbg/Orpk3pcegOgX5HdTLkoDt0= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09DI3F4w081843 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 13:03:15 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 13 Oct 2020 13:03:14 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 13 Oct 2020 13:03:14 -0500 Received: from [10.250.67.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09DI3Dqa005493; Tue, 13 Oct 2020 13:03:14 -0500 Subject: Re: [PATCH] power: supply: bq25980: Fix uninitialized wd_reg_val and overrun To: CC: , , , References: <20201009121205.28178-1-dmurphy@ti.com> From: Dan Murphy Message-ID: Date: Tue, 13 Oct 2020 13:03:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201009121205.28178-1-dmurphy@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian On 10/9/20 7:12 AM, Dan Murphy wrote: > Fix the issue when 'i' is equal to array size then array index over > runs the array when checking for the watch dog value. > > This also fixes the uninitialized wd_reg_val if the for..loop was not > successful in finding an appropriate match. Might want to pull this into next as well this is a 0-day bug fix Dan