From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks
Date: Thu, 15 Oct 2020 11:00:04 +0300 [thread overview]
Message-ID: <f75c5be2-ef40-bd08-dc0b-b025045b15d4@gmail.com> (raw)
In-Reply-To: <20201015093227.y3n5ohzuydg2fe3t@uno.localdomain>
Hello!
On 15.10.2020 12:32, Jacopo Mondi wrote:
[...]
>>> Add clock definitions of the VIN instances for R-Car V3U.
>>>
>>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>>>
>>> ---
>>> Clocks at indexes 730 and 731 are named 'vin0' and 'vin1'.
>>> I assumed it's a typographic error and renamed them 'vin00' and 'vin01'
>>> ---
>>> drivers/clk/renesas/r8a779a0-cpg-mssr.c | 32 +++++++++++++++++++++++++
>>> 1 file changed, 32 insertions(+)
>>>
>>> diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> index bd54a28c50ee..2a00eb82013f 100644
>>> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> @@ -149,6 +149,38 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
>>> DEF_MOD("scif1", 703, R8A779A0_CLK_S1D8),
>>> DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8),
>>> DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8),
>>> + DEF_MOD("vin00", 730, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin01", 731, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin02", 800, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin03", 801, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin04", 802, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin05", 803, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin06", 804, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin07", 805, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin10", 806, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin11", 807, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin12", 808, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin13", 809, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin14", 810, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin15", 811, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin16", 812, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin17", 813, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin20", 814, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin21", 815, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin22", 816, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin23", 817, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin24", 818, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin25", 819, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin26", 820, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin27", 821, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin30", 822, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin31", 823, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin32", 824, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin33", 825, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin34", 826, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin35", 827, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin36", 828, R8A779A0_CLK_S1D1),
>>> + DEF_MOD("vin37", 829, R8A779A0_CLK_S1D1),
>
> There are 32 VIN instances (hence the [0-31] in the subject), grouped
> in 4 units of 8 channels each.
>
> I can drop the [0-31] in the subject if it's confusing.
Please do. :-)
>> The subject says VIN[0-31]?
>>
>> [...]
MBR, Sergei
next prev parent reply other threads:[~2020-10-15 8:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 9:44 [PATCH 0/6] r8a779a0: Add CSI and VIN Jacopo Mondi
2020-10-14 9:44 ` [PATCH 1/6] clk: renesas: r8a779a0: Add CSI4[0-3] clocks Jacopo Mondi
2020-10-15 12:35 ` Geert Uytterhoeven
2020-10-14 9:44 ` [PATCH 2/6] dt-bindings: media: renesas,csi2: Add V3U support Jacopo Mondi
2020-10-14 9:44 ` [PATCH 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes Jacopo Mondi
2020-10-15 12:43 ` Geert Uytterhoeven
2020-10-15 15:12 ` Jacopo Mondi
2020-10-14 9:44 ` [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks Jacopo Mondi
2020-10-14 18:55 ` Sergei Shtylyov
2020-10-15 9:32 ` Jacopo Mondi
2020-10-15 8:00 ` Sergei Shtylyov [this message]
2020-10-15 16:30 ` Geert Uytterhoeven
2020-10-16 10:01 ` Jacopo Mondi
2020-10-14 9:44 ` [PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support Jacopo Mondi
2020-10-14 10:11 ` Niklas Söderlund
2020-10-14 10:27 ` Jacopo Mondi
2020-10-14 9:44 ` [PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes Jacopo Mondi
2020-10-14 10:19 ` Niklas Söderlund
2020-10-14 10:29 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75c5be2-ef40-bd08-dc0b-b025045b15d4@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).