From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: I2C: Add Qualcomm Geni based QUP I2C bindings
Date: Tue, 5 Apr 2022 13:13:05 +0200 [thread overview]
Message-ID: <f7617857-b438-b527-315f-7543b9654a66@linaro.org> (raw)
In-Reply-To: <20220404182938.29492-2-singh.kuldeep87k@gmail.com>
On 04/04/2022 20:29, Kuldeep Singh wrote:
> GENI(generic interface) based Qualcomm Universal Peripheral controller
> can support multiple serial interfaces like SPI,UART and I2C.
>
> Unlike other I2C controllers, QUP I2C bindings are present in parent
> schema. Move it out from parent to an individual binding and let parent
> refer to child schema later on.
>
> Please note, current schema isn't complete as it misses out few
> properties and thus, add these missing properties along the process.
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> v2:
> - Change compatible from enum to const
> - Drop clock-frequency description
> - Sort nodes
> ---
> .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 100 ++++++++++++++++++
> 1 file changed, 100 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-06 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 18:29 [PATCH v2 0/4] Geni based QUP controller binding cleanups Kuldeep Singh
2022-04-04 18:29 ` [PATCH v2 1/4] dt-bindings: I2C: Add Qualcomm Geni based QUP I2C bindings Kuldeep Singh
2022-04-05 11:13 ` Krzysztof Kozlowski [this message]
2022-04-28 1:44 ` Kuldeep Singh
2022-05-03 13:10 ` Rob Herring
2022-04-04 18:29 ` [PATCH v2 2/4] dt-bindings: qcom: geni-se: Update I2C schema reference Kuldeep Singh
2022-04-21 14:27 ` (subset) " Bjorn Andersson
2022-04-04 18:29 ` [PATCH v2 3/4] dt-bindings: serial: Update Qualcomm geni based QUP UART bindings Kuldeep Singh
2022-04-04 18:29 ` [PATCH v2 4/4] dt-bindings: qcom: geni-se: Update UART schema reference Kuldeep Singh
2022-04-21 14:27 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7617857-b438-b527-315f-7543b9654a66@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=singh.kuldeep87k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).