From: John Garry <john.garry@huawei.com>
To: Marco Elver <elver@google.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <jolsa@kernel.org>, <namhyung@kernel.org>,
<leo.yan@linaro.org>, <dvyukov@google.com>, <will@kernel.org>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <linux@armlinux.org.uk>,
<irogers@google.com>, Thomas Richter <tmricht@linux.ibm.com>
Subject: Re: [PATCH] perf test: Skip Sigtrap test for arm+aarch64
Date: Thu, 17 Feb 2022 17:34:23 +0000 [thread overview]
Message-ID: <f7782f09-7f12-b957-a1b2-d0673ec1304c@huawei.com> (raw)
In-Reply-To: <CANpmjNOO6yxF+xXoatR==uvSaEwsWyZ=n7ExEM_=OJaDYBCeSw@mail.gmail.com>
On 17/02/2022 16:45, Marco Elver wrote:
> On Thu, 17 Feb 2022 at 17:28, John Garry <john.garry@huawei.com> wrote:
+ Ian, Thomas
>>
>> Skip the Sigtrap test for arm + arm64, same as was done for s390 in
>> commit a840974e96fd ("perf test: Test 73 Sig_trap fails on s390").
>>
>> As described by Will at [0], in the test we get stuck in a loop of handling
>> the HW breakpoint exception and never making progress. GDB handles this
>> by stepping over the faulting instruction, but with perf the kernel is
>> expected to handle the step (which it doesn't for arm).
>>
>> Dmitry made an attempt to get this work, also mentioned in the same thread
>> as [0], which was appreciated. But the best thing to do is skip the test
>> for now.
>>
>> [0] https://lore.kernel.org/linux-perf-users/20220118124343.GC98966@leoy-ThinkPad-X240s/T/#m13b06c39d2a5100d340f009435df6f4d8ee57b5a
>>
>> Fixes: Fixes: 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")
>> Signed-off-by: John Garry <john.garry@huawei.com>
>>
>> diff --git a/tools/perf/tests/sigtrap.c b/tools/perf/tests/sigtrap.c
>> index 1f147fe6595f..3f0b5c1398b5 100644
>> --- a/tools/perf/tests/sigtrap.c
>> +++ b/tools/perf/tests/sigtrap.c
>> @@ -29,7 +29,8 @@
>> * Just disable the test for these architectures until these issues are
>> * resolved.
>> */
>> -#if defined(__powerpc__) || defined(__s390x__)
>> +#if defined(__powerpc__) || defined(__s390x__) || \
>> + defined(__arm__) || defined(__aarch64__)
>> #define BP_ACCOUNT_IS_SUPPORTED 0
>> #else
>> #define BP_ACCOUNT_IS_SUPPORTED 1
>
> This is now equivalent to BP_SIGNAL_IS_SUPPORTED
> tools/perf/tests/tests.h -- and different from the original
> BP_ACCOUNT_IS_SUPPORTED (and makes me wonder why
> BP_SIGNAL_IS_SUPPORTED wasn't just used from the beginning). Perhaps
> just use BP_SIGNAL_IS_SUPPORTED.
>
We currently have BP_ACCOUNT_IS_SUPPORTED defined now in 2x locations:
tests/sigtrap.c
tests/bp_account.c
bp_account works for arm64, and we don't want to skip that test. So, as
long as the macro meaning is appropriate, we can reuse
BP_SIGNAL_IS_SUPPORTED for sigtrap.c
Thanks,
John
next prev parent reply other threads:[~2022-02-17 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 16:22 [PATCH] perf test: Skip Sigtrap test for arm+aarch64 John Garry
2022-02-17 16:45 ` Marco Elver
2022-02-17 17:34 ` John Garry [this message]
2022-02-17 17:40 ` Marco Elver
2022-02-18 1:58 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7782f09-7f12-b957-a1b2-d0673ec1304c@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).