From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BDCC433FE for ; Tue, 21 Sep 2021 12:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 389D060EE7 for ; Tue, 21 Sep 2021 12:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbhIUMx3 (ORCPT ); Tue, 21 Sep 2021 08:53:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44567 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbhIUMxZ (ORCPT ); Tue, 21 Sep 2021 08:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632228716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqxAQwuwKeUNvwuaTqo1+dLfw9h1X6NxpXvwJl/CpGM=; b=itExvVqPG2cyY/PK7A/KCBqNiE/df2bbBtLHHFCo1VLnElZHsABLHbyhIqp2T0epgOhpkV 3/coGXBkH227QEQ8w6k6U/tD9bR+4iuqkAtEWsiFbcGKQiNfVFF/NaJ63j7We61wQR2+m+ d2GhiNKDqxIw+mRVvkKARliG+Sq7/cE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-QFtRXGZiPYSdUyLgA5hlNA-1; Tue, 21 Sep 2021 08:51:55 -0400 X-MC-Unique: QFtRXGZiPYSdUyLgA5hlNA-1 Received: by mail-ed1-f72.google.com with SMTP id s12-20020a05640217cc00b003cde58450f1so19027741edy.9 for ; Tue, 21 Sep 2021 05:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TqxAQwuwKeUNvwuaTqo1+dLfw9h1X6NxpXvwJl/CpGM=; b=CNQmMxA5saxIu99mP+xeluNYpnOMBG+LxWRuV5K5JQTSLeV4OKYBhynnDHXp9AJ+ap 0w28L8oeR90vTu+0tFroE+AqR+34iOvhemCnapayiAhAo5zKlol6bzcrKDAFNtOkoADc WGExLbU9VFJHZdd+4oPr4LaNeJhyJSJrjIBlU5g8tRxWoGM7safiExxBIR8pR+pzHbib mvpOP+y1Ua6ZDlRs1hkeVRXiSquC8vyCXwRRk9Igw8XkovgQz9470sNSJfAMWFpoyIup wXJRaRp756TWQaIJe0ThIyfzBeN2i+k7Gscb/kd6wvc66XRxjwJ7LiboNBHTiF6dqHHl ZnmQ== X-Gm-Message-State: AOAM531F1o8ciYMohC1cGZ0lIPUFlpfMN/EP/O2jmHRsLPu+Hx3okKPo wE1zndjqdu+LDauRr4sCD7Asiqw7POz7PMtfp5B2apDRofyx0jNTBfYngXk8sC6wBVt5Y2QLakA HCtHlxomkgSDMjseOWAtLJHmh X-Received: by 2002:a17:906:c52:: with SMTP id t18mr34493872ejf.148.1632228714521; Tue, 21 Sep 2021 05:51:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhuiUQhb0tewsqj63rPQftRwt57rxaB6FUVbu3JbDMhgH6wEublWh/IKVcBTwPNrwaAf/NaA== X-Received: by 2002:a17:906:c52:: with SMTP id t18mr34493856ejf.148.1632228714315; Tue, 21 Sep 2021 05:51:54 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id d9sm8435983ede.31.2021.09.21.05.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 05:51:54 -0700 (PDT) Subject: Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Len Brown , Matan Ziv-Av , Mark Gross , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20210916170054.136790-1-krzysztof.kozlowski@canonical.com> <20210916170054.136790-2-krzysztof.kozlowski@canonical.com> From: Hans de Goede Message-ID: Date: Tue, 21 Sep 2021 14:51:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210916170054.136790-2-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote: > BRI0A49 and BDP3336 are already on the list. > > Signed-off-by: Krzysztof Kozlowski Thanks, patch looks good to me: Reviewed-by: Hans de Goede Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86 driver. I'll leave picking this one up to you. Regards, Hans > --- > drivers/acpi/acpi_pnp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c > index 8f2dc176bb41..ffdcfcd4a10d 100644 > --- a/drivers/acpi/acpi_pnp.c > +++ b/drivers/acpi/acpi_pnp.c > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = { > {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */ > {"BRI1400"}, /* Boca Research 33,600 ACF Modem */ > {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */ > - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */ > - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */ > {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */ > {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */ > {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */ >