From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbeCMGMJ (ORCPT ); Tue, 13 Mar 2018 02:12:09 -0400 Received: from esa8.dell-outbound.iphmx.com ([68.232.149.218]:21159 "EHLO esa8.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751483AbeCMGMH (ORCPT ); Tue, 13 Mar 2018 02:12:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2F3AABXa6damGKa6ERdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQlfygKjWONdIIEgRZtk0SCFQqFJQKDGyE0GAECAQEBAQEBAgE?= =?us-ascii?q?CEAEBAQEBCAsLBigugjgigkoBAQEDATo/DAQCAQgRBAEBAR4JB0YJCAIEDgUIh?= =?us-ascii?q?QgIrWGIYYIVhTWCLoZqhSiFYwSaVgmQWoFthDWISY5rgl2BLB6CC3CDEoIyEAy?= =?us-ascii?q?BeXeNVoEYAQEB?= X-IPAS-Result: =?us-ascii?q?A2F3AABXa6damGKa6ERdGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?lfygKjWONdIIEgRZtk0SCFQqFJQKDGyE0GAECAQEBAQEBAgECEAEBAQEBCAsLB?= =?us-ascii?q?igugjgigkoBAQEDATo/DAQCAQgRBAEBAR4JB0YJCAIEDgUIhQgIrWGIYYIVhTW?= =?us-ascii?q?CLoZqhSiFYwSaVgmQWoFthDWISY5rgl2BLB6CC3CDEoIyEAyBeXeNVoEYAQEB?= From: X-LoopCount0: from 10.166.132.189 X-IronPort-AV: E=Sophos;i="5.47,464,1515477600"; d="scan'208";a="1227871285" X-DLP: DLP_GlobalPCIDSS To: CC: , , Subject: RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 Thread-Topic: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 Thread-Index: AQHTujOfjdkuaHq0Pk2UI1enckQ/AqPNMdfggADMJYD//7A9gA== Date: Tue, 13 Mar 2018 06:12:04 +0000 Message-ID: References: <20180312185357.GA1672@light.dominikbrodowski.net> <4cce64d16cab4d499dca9347c1a1f30c@ausx13mpc120.AMER.DELL.COM> <20180313055109.GA14542@light.dominikbrodowski.net> In-Reply-To: <20180313055109.GA14542@light.dominikbrodowski.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w2D6CFej021883 > -----Original Message----- > From: Dominik Brodowski [mailto:linux@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 1:51 PM > To: Limonciello, Mario > Cc: dvhart@infradead.org; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 > > On Mon, Mar 12, 2018 at 10:42:01PM +0000, Mario.Limonciello@dell.com wrote: > > > > > > > -----Original Message----- > > > From: Dominik Brodowski [mailto:linux@dominikbrodowski.net] > > > Sent: Tuesday, March 13, 2018 2:54 AM > > > To: dvhart@infradead.org; Limonciello, Mario > > > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 > > > > > > Mario, > > > > > > unfortunately, my Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016 fails to > > > boot v4.16-rc5. More exactly, I could bisect it down to commit 25d47027e10 > > > ("platform/x86: dell-smbios: Link all dell-smbios-* modules together"). > > > Usually, I have enabled > > > > > > CONFIG_SENSORS_DELL_SMM=y > > > CONFIG_DELL_SMBIOS=y > > > CONFIG_DELL_SMBIOS_WMI=y > > > CONFIG_DELL_SMBIOS_SMM=y > > > CONFIG_DELL_LAPTOP=y > > > CONFIG_DELL_WMI=y > > > CONFIG_DELL_WMI_DESCRIPTOR=y > > > # CONFIG_DELL_WMI_AIO is not set > > > # CONFIG_DELL_WMI_LED is not set > > > # CONFIG_DELL_SMO8800 is not set > > > # CONFIG_DELL_RBTN is not set > > > # CONFIG_DELL_RBU is not set > > > > > > For v4.16-rc5 to work, I need to manually disable DELL_SMBIOS_WMI: > > > > > > -CONFIG_DELL_SMBIOS_WMI=y > > > +# CONFIG_DELL_SMBIOS_WMI is not set > > > > > > Any ideas? > > > > > Dominick, > > > > Interesting. Can you please change CONFIG_DELL_SMBIOS to a module > > and see if that behavior persists? If it does, can you please blacklist it on > > the kernel command line and try to load it manually and share any > > backtrace? > > Mario, > > building and running it as a *module* works flawlessly. But that was > actually expected after a 'grep "initcall"' in drivers/platform/x86: Dominck, Thanks for your checking and explanation of the situation. > > As Darren pointed out, DELL_SMBIOS_WMI depends on ACPI_WMI, so probably > ACPI_WMI needs to be initialized first. However, the all-in-one > dell-smbios.o is run as subsys_initcall(), same as wmi.o > (subsys_initcall_sync() there). > > If both are built-ins, that means that dell-smbios.o is run first, and wmi.o > second. Changing dell-smbios.o to run at the later fs_initcall() level > instead lets me boot the kernel. HOWEVER: > > 1) Is there a reason why both the core and the dell-smbios-smm driver have > to run already at subsys_initcall() time? They did so previous to your > patch. Is it OK to defer these parts opf the all-in-one dell-smbios.o > to fs_initcall(), or even to the default device_initcall()? As long as they're ready before dell-laptop's initialization which uses late_initcall that should be fine. Am I correct to presume you're going to propose a patch you can test and confirm your hypothesis rather than Darren reverting my patch to bring them together? > > 2) dell-smbios-wmi depends on (well, selects) DELL_WMI_DESCRIPTOR. The > dell-smbios-wmi is running at the default device_initcall() time, but > (AFAICS) probably later than the initialization of dell-smbios-wmi.o. > May I presume that this poses no additional problem? > I "think" that should actually be fine. The driver will use deferred probing until it's ready meaning that dell-smbios-wmi should wait until dell-wmi-descriptor is done with it's probing routine.