From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S969708AbdADXbJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 18:31:09 -0500
Received: from mga04.intel.com ([192.55.52.120]:34455 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754029AbdADXbE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 18:31:04 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; 
   d="scan'208";a="919021828"
Subject: Re: [RFC PATCH v3] sparc64: Add support for Application Data
 Integrity (ADI)
To: Khalid Aziz <khalid.aziz@oracle.com>, davem@davemloft.net,
        corbet@lwn.net, arnd@arndb.de, akpm@linux-foundation.org
References: <1483569999-13543-1-git-send-email-khalid.aziz@oracle.com>
Cc: hpa@zytor.com, viro@zeniv.linux.org.uk, nitin.m.gupta@oracle.com,
        chris.hyser@oracle.com, tushar.n.dave@oracle.com,
        sowmini.varadhan@oracle.com, mike.kravetz@oracle.com,
        adam.buchbinder@gmail.com, minchan@kernel.org, hughd@google.com,
        kirill.shutemov@linux.intel.com, keescook@chromium.org,
        allen.pais@oracle.com, aryabinin@virtuozzo.com, atish.patra@oracle.com,
        joe@perches.com, pmladek@suse.com, jslaby@suse.cz,
        cmetcalf@mellanox.com, paul.gortmaker@windriver.com, mhocko@suse.com,
        jmarchan@redhat.com, lstoakes@gmail.com, 0x7f454c46@gmail.com,
        vbabka@suse.cz, tglx@linutronix.de, mingo@redhat.com,
        dan.j.williams@intel.com, iamjoonsoo.kim@lge.com,
        mgorman@techsingularity.net, vdavydov.dev@gmail.com,
        hannes@cmpxchg.org, namit@vmware.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
        linux-arch@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
        Khalid Aziz <khalid@gonehiking.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <f7985965-3e33-4352-0ffb-97a5407f7acc@linux.intel.com>
Date: Wed, 4 Jan 2017 15:31:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1483569999-13543-1-git-send-email-khalid.aziz@oracle.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

One other high-level comment:  It would be nice to see the
arch-independent and x86 portions broken out and explained in their own
right, even if they're small patches.  It's a bit cruel to make us
scroll through a thousand lines of sparc code to see the bits
interesting to us.

It would also be really nice to see a high-level breakdown explaining
what you had to modify, especially since this affects all of the system
calls that take a PROT_* argument.  The sample code is nice, but it's no
substitute for writing it down.